From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [RFC PATCH 1/3] xl: replace vcpu-set --ignore-host with --ignore-warn Date: Wed, 25 Sep 2013 16:32:48 -0400 Message-ID: <20130925203248.GA8827@phenom.dumpdata.com> References: <1374248938-11232-1-git-send-email-konrad.wilk@oracle.com> <1374248938-11232-2-git-send-email-konrad.wilk@oracle.com> <51EDC060.6040608@eu.citrix.com> <20130723140114.GC3795@phenom.dumpdata.com> <51EEC2EC.8060301@eu.citrix.com> <20130723191744.GC7073@phenom.dumpdata.com> <20994.9840.959694.308384@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20994.9840.959694.308384@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: George Dunlap , Konrad Rzeszutek Wilk , "xen-devel@lists.xensource.com" , Ian Campbell List-Id: xen-devel@lists.xenproject.org On Wed, Aug 07, 2013 at 11:50:24AM +0100, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [RFC PATCH 1/3] xl: replace vcpu-set --ignore-host with --ignore-warn"): > > On Tue, Jul 23, 2013 at 8:17 PM, Konrad Rzeszutek Wilk > > > Good point. In which case I think --no-warn and no short option > > > makes the most sense. > > > > TBH the no-warning option seems a bit unnecessary, and a part of me > > thinks just making it possible to do without an override should be > > enough. > > I agree. > > Also we need to keep accepting the previously-introduced option name, > so that existing users don't break. xl should have > forward-compatibility. But we can just ignore the option if the > behaviour it requests becomes the default. I think the following patch does what you guys were thinking of. It neuters the --ignore-host, still prints out the warning (but continues on) and in general allows the system admin to do whatever they want. And adds a blurb in the manpage that the original commit forgot to do (shame on me). Let me send it out as I have one more patch for this. >>From 6170566eb78f86d73a9cc86ac36f7ec0849b1517 Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Fri, 19 Jul 2013 10:15:53 -0400 Subject: [PATCH 1/2] xl: neuter vcpu-set --ignore-host. When Xen 4.3 was released we had a discussion whether we should allow the vcpu-set command to allow the user to set more than physical CPUs for a guest (it didn't). The author brought up: - Xend used to do it, - If a user wants to do it, let them do it, - The original author of the change did not realize the side-effect his patch caused this and had no intention of changing it. - The user can already boot a massively overcommitted guest by having a large 'vcpus=' value in the guest config and we allow that. Since we were close to the release we added --ignore-host parameter as a mechanism for a user to still set more vCPUs that the physical machine as a stop-gate. This patch keeps said option but neuters the check so that we can overcommit. In other words - by default the user is allowed to set as many vCPUs as they would like. Furthermore mention this parameter change in the man-page. Signed-off-by: Konrad Rzeszutek Wilk --- docs/man/xl.pod.1 | 15 ++++++++++++++- tools/libxl/xl_cmdimpl.c | 28 ++++++++++++---------------- tools/libxl/xl_cmdtable.c | 2 +- 3 files changed, 27 insertions(+), 18 deletions(-) diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1 index 5975d7b..1199d01 100644 --- a/docs/man/xl.pod.1 +++ b/docs/man/xl.pod.1 @@ -597,7 +597,7 @@ This command is only available for HVM domains. Moves a domain out of the paused state. This will allow a previously paused domain to now be eligible for scheduling by the Xen hypervisor. -=item B I I +=item B I