From: Tim Deegan <tim@xen.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: julien.grall@linaro.org, stefano.stabellini@eu.citrix.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 7/9] xen: arm: use symbolic names for MPIDR bits.
Date: Thu, 26 Sep 2013 14:22:46 +0100 [thread overview]
Message-ID: <20130926132246.GG54428@ocelot.phlegethon.org> (raw)
In-Reply-To: <1380192556-30700-7-git-send-email-ian.campbell@citrix.com>
At 11:49 +0100 on 26 Sep (1380196154), Ian Campbell wrote:
> arm32 already uses MPIDR_HWID_MASK, use it on arm64 too. Add MPIDR_{SMP,UP}
> (and bitwise equivalents) and use them.
> /* MPIDR Multiprocessor Affinity Register */
> -#define MPIDR_UP (1 << 30)
> -#define MPIDR_SMP (1 << 31)
> +#define _MPIDR_UP (30)
> +#define MPIDR_UP (1 << _MPIDR_UP)
> +#define _MPIDR_SMP (31)
> +#define MPIDR_SMP (1 << _MPIDR_SMP)
Not that you're introducing this, but this should be 1u or 1ul;
1<<31 is undefined. :(
Tim.
next prev parent reply other threads:[~2013-09-26 13:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 10:48 [PATCH v2 0/9] xen: arm: rework early bring up Ian Campbell
2013-09-26 10:49 ` [PATCH v2 1/9] xen: arm: Load xen under 4GB on 32-bit Ian Campbell
2013-09-26 10:49 ` [PATCH v2 2/9] xen: arm: Log the raw MIDR on boot Ian Campbell
2013-09-26 10:49 ` [PATCH v2 3/9] xen: arm: make sure we stay within the memory bank during mm setup Ian Campbell
2013-09-26 11:14 ` Julien Grall
2013-09-26 13:17 ` Tim Deegan
2013-09-26 10:49 ` [PATCH v2 4/9] xen: arm: add two new device tree helpers Ian Campbell
2013-09-26 10:49 ` [PATCH v2 5/9] xen: arm: implement arch/platform SMP and CPU initialisation framework Ian Campbell
2013-09-26 13:47 ` Tim Deegan
2013-09-26 14:06 ` Julien Grall
2013-09-26 14:12 ` Ian Campbell
2013-09-26 10:49 ` [PATCH v2 6/9] xen: arm: rewrite start of day page table and cpu bring up Ian Campbell
2013-09-26 12:59 ` Ian Campbell
2013-09-26 14:31 ` Tim Deegan
2013-09-26 10:49 ` [PATCH v2 7/9] xen: arm: use symbolic names for MPIDR bits Ian Campbell
2013-09-26 13:22 ` Tim Deegan [this message]
2013-09-26 13:35 ` Ian Campbell
2013-09-26 13:45 ` Tim Deegan
2013-09-26 10:49 ` [PATCH v2 8/9] xen: arm: configure TCR_EL2 for 40 bit physical address space Ian Campbell
2013-09-26 10:49 ` [PATCH v2 9/9] xen: arm: split cpu0's domheap mapping PTs out from xen_second Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130926132246.GG54428@ocelot.phlegethon.org \
--to=tim@xen.org \
--cc=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).