From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Deegan <tim@xen.org>
Subject: Re: [PATCH v2 7/9] xen: arm: use symbolic names for
	MPIDR bits.
Date: Thu, 26 Sep 2013 14:22:46 +0100
Message-ID: <20130926132246.GG54428@ocelot.phlegethon.org>
References: <1380192538.29483.63.camel@kazak.uk.xensource.com>
	<1380192556-30700-7-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1380192556-30700-7-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: julien.grall@linaro.org, stefano.stabellini@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

At 11:49 +0100 on 26 Sep (1380196154), Ian Campbell wrote:
> arm32 already uses MPIDR_HWID_MASK, use it on arm64 too. Add MPIDR_{SMP,UP}
> (and bitwise equivalents) and use them.
>  /* MPIDR Multiprocessor Affinity Register */
> -#define MPIDR_UP            (1 << 30)
> -#define MPIDR_SMP           (1 << 31)
> +#define _MPIDR_UP           (30)
> +#define MPIDR_UP            (1 << _MPIDR_UP)
> +#define _MPIDR_SMP          (31)
> +#define MPIDR_SMP           (1 << _MPIDR_SMP)

Not that you're introducing this, but this should be 1u or 1ul; 
1<<31 is undefined.  :(

Tim.