From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [RFC 0 PATCH 2/3] PVH dom0: move some pv specific
 code to static functions
Date: Thu, 26 Sep 2013 16:32:06 -0700
Message-ID: <20130926163206.7aabc9df@mantra.us.oracle.com>
References: <1380142988-9487-1-git-send-email-mukesh.rathor@oracle.com>
	<1380142988-9487-3-git-send-email-mukesh.rathor@oracle.com>
	<5243FCA102000078000F6975@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <mukesh.rathor@oracle.com>) id 1VPL2e-0007Kw-Jy
	for xen-devel@lists.xenproject.org; Thu, 26 Sep 2013 23:32:16 +0000
In-Reply-To: <5243FCA102000078000F6975@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, keir.xen@gmail.com
List-Id: xen-devel@lists.xenproject.org

On Thu, 26 Sep 2013 08:21:37 +0100
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 25.09.13 at 23:03, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> > +static __init void setup_pv_p2m_table(
> 
...
> > +            if ( l3tab )
> > +            {
> > +                unmap_domain_page(l3tab);
> > +                l3tab = NULL;
> > +            }
> > +            l4tab = l4start + l4_table_offset(va);
> 
> The way this l4tab gets used here (and l[123]tab below) makes
> these names bogus - they should be pl[1234]e instead. The
> original uses were just attributed to the desire of re-using
> existing variables, which is mute with this stuff getting moved
> into its own function.
> 
> This also applies to the similarly named variables in
> mark_pv_pt_pages_rdonly().

Ok, all done. Also, noticed the exhisting code for 
mark_pv_pt_pages_rdonly unnecessarily sets l[321]start
in two places.

thanks
mukesh