From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [PATCH RFC v13 08/20] pvh: PVH access to hypercalls
Date: Fri, 27 Sep 2013 14:15:41 -0700
Message-ID: <20130927141541.2b4e003f@mantra.us.oracle.com>
References: <1379955000-11050-1-git-send-email-george.dunlap@eu.citrix.com>
	<1379955000-11050-9-git-send-email-george.dunlap@eu.citrix.com>
	<52446FD302000078000F70E8@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <mukesh.rathor@oracle.com>) id 1VPfOG-0002o6-Ui
	for xen-devel@lists.xenproject.org; Fri, 27 Sep 2013 21:15:57 +0000
In-Reply-To: <52446FD302000078000F70E8@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, 26 Sep 2013 16:33:07 +0100
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 23.09.13 at 18:49, George Dunlap <george.dunlap@eu.citrix.com>
> >>> wrote:
> > --- a/xen/arch/x86/hvm/mtrr.c
> > +++ b/xen/arch/x86/hvm/mtrr.c
> > @@ -578,6 +578,7 @@ int32_t hvm_set_mem_pinned_cacheattr(
> >  {
> >      struct hvm_mem_pinned_cacheattr_range *range;
> >  
> > +    /* Side note: A PVH guest writes to MSR_IA32_CR_PAT natively.
> > */ if ( !((type == PAT_TYPE_UNCACHABLE) ||
> >             (type == PAT_TYPE_WRCOMB) ||
> >             (type == PAT_TYPE_WRTHROUGH) ||
> 
> I always wondered what this comment is trying to tell the
> reader.

Original code:

    /* Side note: A PVH guest writes to MSR_IA32_CR_PAT natively. */
    if ( is_pvh_domain(d) )
        return -EOPNOTSUPP;

We don't support this because the guest writes PAT natively, was 
my intention. Either it was your comment to return EOPNOTSUPP
or just my thought - it will return EINVAL now, I guess ok too.

thanks
mukesh