From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: David Vrabel <dvrabel@cantab.net>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 01/16] xen/events: refactor retrigger_dynirq() and resend_irq_on_evtchn()
Date: Wed, 2 Oct 2013 17:08:15 -0400 [thread overview]
Message-ID: <20131002210815.GA25661@phenom.dumpdata.com> (raw)
In-Reply-To: <524C8999.5020508@cantab.net>
On Wed, Oct 02, 2013 at 10:01:13PM +0100, David Vrabel wrote:
> On 02/10/2013 21:43, Konrad Rzeszutek Wilk wrote:
> > On Wed, Oct 02, 2013 at 06:14:46PM +0100, David Vrabel wrote:
> >> From: David Vrabel <david.vrabel@citrix.com>
> >>
> >> These two function did the same thing with different parameters, put
> >> the common bits in retrigger_evtchn().
> >>
> >> This changes the return value of resend_irq_on_evtchn() but the only
> >> caller (in arch/ia64/xen/irq_xen.c) ignored the return value so this
> >> is fine.
> >>
> >> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> >
> > Hm, I thought I acked it?
>
> You said "Looks good to me" which wasn't official enough to add as a tag.
It is in the Linux kernel, see Documentation/SubmittingPatches:
13) When to use Acked-by: and Cc:
The Signed-off-by: tag indicates that the signer was involved in the
development of the patch, or that he/she was in the patch's delivery path.
If a person was not directly involved in the preparation or handling of a
patch but wishes to signify and record their approval of it then they can
arrange to have an Acked-by: line added to the patch's changelog.
Acked-by: is often used by the maintainer of the affected code when that
maintainer neither contributed to nor forwarded the patch.
Acked-by: is not as formal as Signed-off-by:. It is a record that the acker
has at least reviewed the patch and has indicated acceptance. Hence patch
mergers will sometimes manually convert an acker's "yep, looks good to me"
into an Acked-by:.
>
> David
next prev parent reply other threads:[~2013-10-02 21:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 17:14 [PATCHv5 00/16] Linux: FIFO-based event channel ABI David Vrabel
2013-10-02 17:14 ` [PATCH 01/16] xen/events: refactor retrigger_dynirq() and resend_irq_on_evtchn() David Vrabel
2013-10-02 20:43 ` Konrad Rzeszutek Wilk
2013-10-02 21:01 ` David Vrabel
2013-10-02 21:08 ` Konrad Rzeszutek Wilk [this message]
2013-10-02 22:06 ` David Vrabel
2013-10-02 17:14 ` [PATCH 02/16] xen/events: remove unnecessary init_evtchn_cpu_bindings() David Vrabel
2013-10-02 17:14 ` [PATCH 03/16] xen/events: introduce test_and_set_mask David Vrabel
2013-10-02 17:14 ` [PATCH 04/16] xen/events: replace raw bit ops with functions David Vrabel
2013-10-02 17:14 ` [PATCH 05/16] xen/events: move drivers/xen/events.c into drivers/xen/events/ David Vrabel
2013-10-02 17:14 ` [PATCH 06/16] xen/events: move 2-level specific code into its own file David Vrabel
2013-10-02 17:14 ` [PATCH 07/16] xen/events: add struct evtchn_ops for the low-level port operations David Vrabel
2013-10-02 17:14 ` [PATCH 08/16] xen/events: allow setup of irq_info to fail David Vrabel
2013-10-02 17:14 ` [PATCH 09/16] xen/events: add a evtchn_op for port setup David Vrabel
2013-10-02 17:14 ` [PATCH 10/16] xen/events: Refactor evtchn_to_irq array to be dynamically allocated David Vrabel
2013-10-02 17:14 ` [PATCH 11/16] xen/events: add xen_evtchn_mask_all() David Vrabel
2013-10-02 17:14 ` [PATCH 12/16] xen/evtchn: support more than 4096 ports David Vrabel
2013-10-02 17:14 ` [PATCH 13/16] xen/events: Add the hypervisor interface for the FIFO-based event channels David Vrabel
2013-10-02 17:14 ` [PATCH 14/16] xen/events: allow event channel priority to be set David Vrabel
2013-10-02 17:15 ` [PATCH 15/16] xen/x86: set VIRQ_TIMER priority to maximum David Vrabel
2013-10-02 17:15 ` [PATCH 16/16] xen/events: use the FIFO-based ABI if available David Vrabel
-- strict thread matches above, loose matches on Subject: below --
2013-10-08 12:48 [PATCHv6 00/16] Linux: FIFO-based event channel ABI David Vrabel
2013-10-08 12:49 ` [PATCH 01/16] xen/events: refactor retrigger_dynirq() and resend_irq_on_evtchn() David Vrabel
2013-10-14 15:59 ` Boris Ostrovsky
2013-10-14 16:35 ` David Vrabel
2013-10-18 14:23 [PATCHv7 00/16] Linux: FIFO-based event channel ABI David Vrabel
2013-10-18 14:23 ` [PATCH 01/16] xen/events: refactor retrigger_dynirq() and resend_irq_on_evtchn() David Vrabel
2013-10-31 15:09 [PATCHv8 00/16] Linux: FIFO-based event channel ABI David Vrabel
2013-10-31 15:09 ` [PATCH 01/16] xen/events: refactor retrigger_dynirq() and resend_irq_on_evtchn() David Vrabel
2013-11-11 16:12 [PATCHv9 00/16] Linux: FIFO-based event channel ABI David Vrabel
2013-11-11 16:12 ` [PATCH 01/16] xen/events: refactor retrigger_dynirq() and resend_irq_on_evtchn() David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131002210815.GA25661@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=dvrabel@cantab.net \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).