* [PATCH] qemu-traditional: do not strip binaries during make install
@ 2012-12-05 18:42 Olaf Hering
2013-01-16 15:47 ` Olaf Hering
0 siblings, 1 reply; 10+ messages in thread
From: Olaf Hering @ 2012-12-05 18:42 UTC (permalink / raw)
To: xen-devel; +Cc: Olaf Hering
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
Makefile | 2 +-
Makefile.target | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 37c7066..594f0ef 100644
--- a/Makefile
+++ b/Makefile
@@ -243,7 +243,7 @@ endif
install: all $(if $(BUILD_DOCS),install-doc)
mkdir -p "$(DESTDIR)$(bindir)"
ifneq ($(TOOLS),)
- $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
+ $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
endif
ifneq ($(BLOBS),)
mkdir -p "$(DESTDIR)$(datadir)"
diff --git a/Makefile.target b/Makefile.target
index 19bb0fd..1cf7f34 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -755,7 +755,7 @@ clean:
install: all install-hook
ifneq ($(PROGS),)
- $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
+ $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
endif
# Include automatically generated dependency files
--
1.8.0.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] qemu-traditional: do not strip binaries during make install
2012-12-05 18:42 Olaf Hering
@ 2013-01-16 15:47 ` Olaf Hering
2013-04-29 13:40 ` Olaf Hering
0 siblings, 1 reply; 10+ messages in thread
From: Olaf Hering @ 2013-01-16 15:47 UTC (permalink / raw)
To: xen-devel
ping
On Wed, Dec 05, Olaf Hering wrote:
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
> Makefile | 2 +-
> Makefile.target | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 37c7066..594f0ef 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -243,7 +243,7 @@ endif
> install: all $(if $(BUILD_DOCS),install-doc)
> mkdir -p "$(DESTDIR)$(bindir)"
> ifneq ($(TOOLS),)
> - $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> + $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
> endif
> ifneq ($(BLOBS),)
> mkdir -p "$(DESTDIR)$(datadir)"
> diff --git a/Makefile.target b/Makefile.target
> index 19bb0fd..1cf7f34 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -755,7 +755,7 @@ clean:
>
> install: all install-hook
> ifneq ($(PROGS),)
> - $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
> + $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
> endif
>
> # Include automatically generated dependency files
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] qemu-traditional: do not strip binaries during make install
2013-01-16 15:47 ` Olaf Hering
@ 2013-04-29 13:40 ` Olaf Hering
2013-05-01 16:22 ` Matt Wilson
0 siblings, 1 reply; 10+ messages in thread
From: Olaf Hering @ 2013-04-29 13:40 UTC (permalink / raw)
To: xen-devel
Ping
On Wed, Jan 16, Olaf Hering wrote:
> ping
> On Wed, Dec 05, Olaf Hering wrote:
>
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > ---
> > Makefile | 2 +-
> > Makefile.target | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 37c7066..594f0ef 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -243,7 +243,7 @@ endif
> > install: all $(if $(BUILD_DOCS),install-doc)
> > mkdir -p "$(DESTDIR)$(bindir)"
> > ifneq ($(TOOLS),)
> > - $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> > + $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
> > endif
> > ifneq ($(BLOBS),)
> > mkdir -p "$(DESTDIR)$(datadir)"
> > diff --git a/Makefile.target b/Makefile.target
> > index 19bb0fd..1cf7f34 100644
> > --- a/Makefile.target
> > +++ b/Makefile.target
> > @@ -755,7 +755,7 @@ clean:
> >
> > install: all install-hook
> > ifneq ($(PROGS),)
> > - $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
> > + $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
> > endif
> >
> > # Include automatically generated dependency files
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] qemu-traditional: do not strip binaries during make install
2013-04-29 13:40 ` Olaf Hering
@ 2013-05-01 16:22 ` Matt Wilson
0 siblings, 0 replies; 10+ messages in thread
From: Matt Wilson @ 2013-05-01 16:22 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel
On Mon, Apr 29, 2013 at 03:40:27PM +0200, Olaf Hering wrote:
> Ping
I've been hit by the "where are the debug symbols for this binary"
problem for qemu in the past. Makes sense to me.
Acked-by: Matt Wilson <msw@amazon.com>
> On Wed, Jan 16, Olaf Hering wrote:
>
> > ping
> > On Wed, Dec 05, Olaf Hering wrote:
> >
> > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > > ---
> > > Makefile | 2 +-
> > > Makefile.target | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index 37c7066..594f0ef 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -243,7 +243,7 @@ endif
> > > install: all $(if $(BUILD_DOCS),install-doc)
> > > mkdir -p "$(DESTDIR)$(bindir)"
> > > ifneq ($(TOOLS),)
> > > - $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> > > + $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
> > > endif
> > > ifneq ($(BLOBS),)
> > > mkdir -p "$(DESTDIR)$(datadir)"
> > > diff --git a/Makefile.target b/Makefile.target
> > > index 19bb0fd..1cf7f34 100644
> > > --- a/Makefile.target
> > > +++ b/Makefile.target
> > > @@ -755,7 +755,7 @@ clean:
> > >
> > > install: all install-hook
> > > ifneq ($(PROGS),)
> > > - $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
> > > + $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
> > > endif
> > >
> > > # Include automatically generated dependency files
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] qemu-traditional: do not strip binaries during make install
@ 2013-09-18 18:11 Olaf Hering
2013-09-19 0:21 ` Matthew Daley
2013-10-10 17:19 ` Ian Jackson
0 siblings, 2 replies; 10+ messages in thread
From: Olaf Hering @ 2013-09-18 18:11 UTC (permalink / raw)
To: xen-devel; +Cc: Olaf Hering, Ian.Jackson, Ian.Campbell
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Matt Wilson <msw@amazon.com>
---
Makefile | 2 +-
Makefile.target | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 37c7066..594f0ef 100644
--- a/Makefile
+++ b/Makefile
@@ -243,7 +243,7 @@ endif
install: all $(if $(BUILD_DOCS),install-doc)
mkdir -p "$(DESTDIR)$(bindir)"
ifneq ($(TOOLS),)
- $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
+ $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
endif
ifneq ($(BLOBS),)
mkdir -p "$(DESTDIR)$(datadir)"
diff --git a/Makefile.target b/Makefile.target
index 19bb0fd..1cf7f34 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -755,7 +755,7 @@ clean:
install: all install-hook
ifneq ($(PROGS),)
- $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
+ $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
endif
# Include automatically generated dependency files
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] qemu-traditional: do not strip binaries during make install
2013-09-18 18:11 [PATCH] qemu-traditional: do not strip binaries during make install Olaf Hering
@ 2013-09-19 0:21 ` Matthew Daley
2013-09-19 7:41 ` Olaf Hering
2013-10-10 17:19 ` Ian Jackson
1 sibling, 1 reply; 10+ messages in thread
From: Matthew Daley @ 2013-09-19 0:21 UTC (permalink / raw)
To: Olaf Hering; +Cc: Ian Jackson, Ian Campbell, xen-devel@lists.xen.org
On Thu, Sep 19, 2013 at 6:11 AM, Olaf Hering <olaf@aepfle.de> wrote:
> @@ -243,7 +243,7 @@ endif
> install: all $(if $(BUILD_DOCS),install-doc)
> mkdir -p "$(DESTDIR)$(bindir)"
> ifneq ($(TOOLS),)
> - $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> + $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
> endif
> ifneq ($(BLOBS),)
> mkdir -p "$(DESTDIR)$(datadir)"
> diff --git a/Makefile.target b/Makefile.target
> index 19bb0fd..1cf7f34 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -755,7 +755,7 @@ clean:
>
> install: all install-hook
> ifneq ($(PROGS),)
> - $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
> + $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
Perhaps it would be worthwhile to only do this if debug=y is set, like
in commit 8e4610e (which is the equivalent of this patch for
qemu-xen)?
- Matthew
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] qemu-traditional: do not strip binaries during make install
2013-09-19 0:21 ` Matthew Daley
@ 2013-09-19 7:41 ` Olaf Hering
0 siblings, 0 replies; 10+ messages in thread
From: Olaf Hering @ 2013-09-19 7:41 UTC (permalink / raw)
To: Matthew Daley; +Cc: Ian Jackson, Ian Campbell, xen-devel@lists.xen.org
On Thu, Sep 19, Matthew Daley wrote:
> On Thu, Sep 19, 2013 at 6:11 AM, Olaf Hering <olaf@aepfle.de> wrote:
> > @@ -243,7 +243,7 @@ endif
> > install: all $(if $(BUILD_DOCS),install-doc)
> > mkdir -p "$(DESTDIR)$(bindir)"
> > ifneq ($(TOOLS),)
> > - $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> > + $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
> > endif
> > ifneq ($(BLOBS),)
> > mkdir -p "$(DESTDIR)$(datadir)"
> > diff --git a/Makefile.target b/Makefile.target
> > index 19bb0fd..1cf7f34 100644
> > --- a/Makefile.target
> > +++ b/Makefile.target
> > @@ -755,7 +755,7 @@ clean:
> >
> > install: all install-hook
> > ifneq ($(PROGS),)
> > - $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
> > + $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
>
> Perhaps it would be worthwhile to only do this if debug=y is set, like
> in commit 8e4610e (which is the equivalent of this patch for
> qemu-xen)?
I dont think any "make install" has to modify the binaries. If debuginfo
was requested by passing "-g" via CFLAGS then the generated debuginfo
has to be preserved during make install.
Olaf
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] qemu-traditional: do not strip binaries during make install
2013-09-18 18:11 [PATCH] qemu-traditional: do not strip binaries during make install Olaf Hering
2013-09-19 0:21 ` Matthew Daley
@ 2013-10-10 17:19 ` Ian Jackson
2013-10-14 15:29 ` Olaf Hering
1 sibling, 1 reply; 10+ messages in thread
From: Ian Jackson @ 2013-10-10 17:19 UTC (permalink / raw)
To: Olaf Hering; +Cc: Ian.Campbell, xen-devel
Olaf Hering writes ("[PATCH] qemu-traditional: do not strip binaries during make install"):
> diff --git a/Makefile b/Makefile
> index 37c7066..594f0ef 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -243,7 +243,7 @@ endif
> install: all $(if $(BUILD_DOCS),install-doc)
> mkdir -p "$(DESTDIR)$(bindir)"
> ifneq ($(TOOLS),)
> - $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> + $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
...
I agree that the existing code is wrong but I worry that we are
replacing "cannot get it not to strip" with "cannot get it to strip".
Can you also replace the relevant $(INSTALL) with $(INSTALL_PROGRAM)
(defined appropriately if necessary) ?
Thanks,
Ian.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] qemu-traditional: do not strip binaries during make install
2013-10-10 17:19 ` Ian Jackson
@ 2013-10-14 15:29 ` Olaf Hering
0 siblings, 0 replies; 10+ messages in thread
From: Olaf Hering @ 2013-10-14 15:29 UTC (permalink / raw)
To: Ian Jackson; +Cc: Ian.Campbell, xen-devel
On Thu, Oct 10, Ian Jackson wrote:
> Olaf Hering writes ("[PATCH] qemu-traditional: do not strip binaries during make install"):
> > diff --git a/Makefile b/Makefile
> > index 37c7066..594f0ef 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -243,7 +243,7 @@ endif
> > install: all $(if $(BUILD_DOCS),install-doc)
> > mkdir -p "$(DESTDIR)$(bindir)"
> > ifneq ($(TOOLS),)
> > - $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> > + $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
> ...
>
> I agree that the existing code is wrong but I worry that we are
> replacing "cannot get it not to strip" with "cannot get it to strip".
>
> Can you also replace the relevant $(INSTALL) with $(INSTALL_PROGRAM)
> (defined appropriately if necessary) ?
I will test this patch:
It is wrong to strip code during make install, unless explicit
requested. Introduce a new variable INSTALL_PROG and use it along with
an optional STRIP_OPT where currently install -s -m 755 is used.
This is what upstream qemu offers in version 1.6.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
Makefile | 2 +-
Makefile.target | 2 +-
configure | 1 +
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 37c7066..ed9b28a 100644
--- a/Makefile
+++ b/Makefile
@@ -243,7 +243,7 @@ endif
install: all $(if $(BUILD_DOCS),install-doc)
mkdir -p "$(DESTDIR)$(bindir)"
ifneq ($(TOOLS),)
- $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
+ $(INSTALL_PROG) $(STRIP_OPT) $(TOOLS) "$(DESTDIR)$(bindir)"
endif
ifneq ($(BLOBS),)
mkdir -p "$(DESTDIR)$(datadir)"
diff --git a/Makefile.target b/Makefile.target
index 19bb0fd..3c3db2b 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -755,7 +755,7 @@ clean:
install: all install-hook
ifneq ($(PROGS),)
- $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
+ $(INSTALL_PROG) $(STRIP_OPT) $(PROGS) "$(DESTDIR)$(bindir)"
endif
# Include automatically generated dependency files
diff --git a/configure b/configure
index ace3c3e..4547359 100755
--- a/configure
+++ b/configure
@@ -1215,6 +1215,7 @@ echo "docdir=\${prefix}$docsuffix" >> $config_mak
echo "#define CONFIG_QEMU_SHAREDIR \"$prefix$datasuffix\"" >> $config_h
echo "MAKE=$make" >> $config_mak
echo "INSTALL=$install" >> $config_mak
+echo "INSTALL_PROG=$install -m 0755" >> $config_mak
echo "CC=$cc" >> $config_mak
echo "HOST_CC=$host_cc" >> $config_mak
echo "AR=$ar" >> $config_mak
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] qemu-traditional: do not strip binaries during make install
@ 2013-10-15 9:42 Olaf Hering
0 siblings, 0 replies; 10+ messages in thread
From: Olaf Hering @ 2013-10-15 9:42 UTC (permalink / raw)
To: xen-devel; +Cc: Olaf Hering, Ian.Jackson, Ian.Campbell
It is wrong to strip code during make install, unless explicit
requested. Introduce a new variable INSTALL_PROG and use it along with
an optional STRIP_OPT where currently install -s -m 755 is used.
This is what upstream qemu offers in version 1.6.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
Makefile | 2 +-
Makefile.target | 2 +-
configure | 1 +
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 37c7066..ed9b28a 100644
--- a/Makefile
+++ b/Makefile
@@ -243,7 +243,7 @@ endif
install: all $(if $(BUILD_DOCS),install-doc)
mkdir -p "$(DESTDIR)$(bindir)"
ifneq ($(TOOLS),)
- $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
+ $(INSTALL_PROG) $(STRIP_OPT) $(TOOLS) "$(DESTDIR)$(bindir)"
endif
ifneq ($(BLOBS),)
mkdir -p "$(DESTDIR)$(datadir)"
diff --git a/Makefile.target b/Makefile.target
index 19bb0fd..3c3db2b 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -755,7 +755,7 @@ clean:
install: all install-hook
ifneq ($(PROGS),)
- $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
+ $(INSTALL_PROG) $(STRIP_OPT) $(PROGS) "$(DESTDIR)$(bindir)"
endif
# Include automatically generated dependency files
diff --git a/configure b/configure
index ace3c3e..4547359 100755
--- a/configure
+++ b/configure
@@ -1215,6 +1215,7 @@ echo "docdir=\${prefix}$docsuffix" >> $config_mak
echo "#define CONFIG_QEMU_SHAREDIR \"$prefix$datasuffix\"" >> $config_h
echo "MAKE=$make" >> $config_mak
echo "INSTALL=$install" >> $config_mak
+echo "INSTALL_PROG=$install -m 0755" >> $config_mak
echo "CC=$cc" >> $config_mak
echo "HOST_CC=$host_cc" >> $config_mak
echo "AR=$ar" >> $config_mak
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-10-15 9:42 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-18 18:11 [PATCH] qemu-traditional: do not strip binaries during make install Olaf Hering
2013-09-19 0:21 ` Matthew Daley
2013-09-19 7:41 ` Olaf Hering
2013-10-10 17:19 ` Ian Jackson
2013-10-14 15:29 ` Olaf Hering
-- strict thread matches above, loose matches on Subject: below --
2013-10-15 9:42 Olaf Hering
2012-12-05 18:42 Olaf Hering
2013-01-16 15:47 ` Olaf Hering
2013-04-29 13:40 ` Olaf Hering
2013-05-01 16:22 ` Matt Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).