From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Rathor Subject: Re: [V1 PATCH 03/11] PVH dom0: iommu related changes Date: Thu, 14 Nov 2013 17:43:00 -0800 Message-ID: <20131114174300.56c070cf@mantra.us.oracle.com> References: <1383960215-22444-1-git-send-email-mukesh.rathor@oracle.com> <1383960215-22444-4-git-send-email-mukesh.rathor@oracle.com> <528260A3020000780010288F@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Vh8RA-0002Cc-P1 for xen-devel@lists.xenproject.org; Fri, 15 Nov 2013 01:43:08 +0000 In-Reply-To: <528260A3020000780010288F@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , keir.xen@gmail.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 12 Nov 2013 16:08:51 +0000 "Jan Beulich" wrote: > >>> On 09.11.13 at 02:23, Mukesh Rathor > >>> wrote: > > --- a/xen/drivers/passthrough/iommu.c > > +++ b/xen/drivers/passthrough/iommu.c > > @@ -125,15 +125,27 @@ int iommu_domain_init(struct domain *d) > > return hd->platform_ops->init(d); > > } > > > > +static inline void check_dom0_pvh_reqs(struct domain *d) > > No point for this to be an inline function. Even more, irrespective > of whether it is, it should also be marked __init. Ok, marked __init, removed inline. Or did you mean get rid of the function and move checks to iommu_dom0_init()? thanks, m