From: Wei Liu <wei.liu2@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH RFC 4/4] hvmloader:ovmf: setup E820 map
Date: Tue, 19 Nov 2013 20:05:25 +0000 [thread overview]
Message-ID: <20131119200525.GC12622@zion.uk.xensource.com> (raw)
In-Reply-To: <20131119195631.GA7921@phenom.dumpdata.com>
On Tue, Nov 19, 2013 at 02:56:31PM -0500, Konrad Rzeszutek Wilk wrote:
> On Fri, Nov 15, 2013 at 03:59:25PM +0000, Wei Liu wrote:
> > E820 map will be used by OVMF to create memory map.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> > tools/firmware/hvmloader/ovmf.c | 13 ++++++++++++-
> > 1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/firmware/hvmloader/ovmf.c b/tools/firmware/hvmloader/ovmf.c
> > index c253083..52ccd0d 100644
> > --- a/tools/firmware/hvmloader/ovmf.c
> > +++ b/tools/firmware/hvmloader/ovmf.c
> > @@ -128,6 +128,17 @@ static void ovmf_create_smbios_tables(void)
> > SMBIOS_PHYSICAL_END);
> > }
> >
> > +static void ovmf_setup_e820(void)
> > +{
> > + struct ovmf_info *info = (void *)OVMF_INFO_PHYSICAL_ADDRESS;
> > + struct e820entry *e820 = scratch_alloc(sizeof(struct e820entry)*16, 0);
>
> 16? Why not 128 (the default in most kernels)?
Aye, sir. :-)
Wei.
next prev parent reply other threads:[~2013-11-19 20:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 15:59 [PATCH RFC 0/4] hvmloader: make OVMF work with Xen Wei Liu
2013-11-15 15:59 ` [PATCH RFC 1/4] hvmloader/ovmf: increase blob size to 2MB Wei Liu
2013-11-19 17:49 ` Ian Campbell
2013-11-19 20:49 ` Wei Liu
2013-11-20 10:13 ` Ian Campbell
2013-11-15 15:59 ` [PATCH RFC 2/4] hvmloader/ovmf: show OVMF_BEGIN as bios address Wei Liu
2013-11-19 17:51 ` Ian Campbell
2013-11-15 15:59 ` [PATCH RFC 3/4] hvmloader/ovmf: setup ovmf_info Wei Liu
2013-11-19 17:54 ` Ian Campbell
2013-11-19 18:03 ` Wei Liu
2013-11-20 10:08 ` Ian Campbell
2013-11-15 15:59 ` [PATCH RFC 4/4] hvmloader:ovmf: setup E820 map Wei Liu
2013-11-19 17:56 ` Ian Campbell
2013-11-19 18:01 ` Wei Liu
2013-11-20 10:07 ` Ian Campbell
2013-11-20 11:49 ` Wei Liu
2013-11-20 11:51 ` Ian Campbell
2013-11-20 11:58 ` Wei Liu
2013-11-20 12:11 ` Ian Campbell
2013-11-20 12:19 ` Wei Liu
2013-11-19 19:56 ` Konrad Rzeszutek Wilk
2013-11-19 20:05 ` Wei Liu [this message]
2013-11-20 10:12 ` Ian Campbell
2013-11-20 14:04 ` Konrad Rzeszutek Wilk
2013-11-20 14:05 ` Ian Campbell
2013-11-19 17:47 ` [PATCH RFC 0/4] hvmloader: make OVMF work with Xen Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119200525.GC12622@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).