xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>,
	Tim Deegan <tim@xen.org>, Eddie Dong <eddie.dong@intel.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	xen-devel@lists.xenproject.org,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 2/2] pvh: set only minimal cr0 and cr4 flags in order to use paging
Date: Mon, 25 Nov 2013 14:39:11 -0800	[thread overview]
Message-ID: <20131125143911.206998b6@mantra.us.oracle.com> (raw)
In-Reply-To: <5293647F.3000200@eu.citrix.com>

On Mon, 25 Nov 2013 14:53:51 +0000
George Dunlap <george.dunlap@eu.citrix.com> wrote:

> On 11/25/2013 01:25 PM, Jan Beulich wrote:
> >>>> On 19.11.13 at 13:34, Roger Pau Monne <roger.pau@citrix.com>
> >>>> wrote:
> >> Right now Xen sets the WP and NE flags on cr0 for PVH, which are
> >> not needed in order to boot with paging enabled. The same happens
> >> with cr4, at least on my system OSFXSR, OSXMMEXCPT and MCE are
> >> enabled by default when there's no need.
> >>
> >> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > So I'm still having this patch sitting in my queue, and I don't
> > think I've seen an ack from the VMX maintainers or the main PVH
> > contributors. At least one of the two I'd like to have in place
> > before applying.
> 
> This sounds like a good idea to me, but I don't feel like I have a
> firm enough grasp to give a reviewed-by; so:
> 
> Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
> 

Also,

Acked-by: Mukesh Rathor <mukesh.rathor@oracle.com>

thanks
mukesh

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-11-25 22:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19 12:34 [PATCH 1/2] pvh: proposed BSP/AP bringup changes Roger Pau Monne
2013-11-19 12:34 ` [PATCH 1/2] pvh: clearly specify used parameters in vcpu_guest_context Roger Pau Monne
2013-11-19 13:32   ` Jan Beulich
2013-11-19 15:04     ` Roger Pau Monné
2013-11-19 15:34       ` Jan Beulich
2013-11-19 16:42         ` Roger Pau Monné
2013-11-19 16:53           ` Jan Beulich
2013-11-20  9:18             ` Roger Pau Monné
2013-11-20  9:28               ` Jan Beulich
2013-11-20  9:37                 ` Roger Pau Monné
2013-11-20  9:54                   ` Jan Beulich
2013-11-20 10:29                     ` Roger Pau Monné
2013-11-20 18:19                       ` George Dunlap
2013-11-20 18:24                         ` Roger Pau Monné
2013-11-20 21:19                           ` Mukesh Rathor
2013-11-22 17:38                       ` George Dunlap
2013-11-21 13:16         ` Tim Deegan
2013-11-19 12:34 ` [PATCH 2/2] pvh: set only minimal cr0 and cr4 flags in order to use paging Roger Pau Monne
2013-11-19 13:34   ` Jan Beulich
2013-11-25 13:25   ` Jan Beulich
2013-11-25 14:53     ` George Dunlap
2013-11-25 22:39       ` Mukesh Rathor [this message]
2013-11-26  0:29   ` Dong, Eddie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131125143911.206998b6@mantra.us.oracle.com \
    --to=mukesh.rathor@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=eddie.dong@intel.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=jun.nakajima@intel.com \
    --cc=keir@xen.org \
    --cc=roger.pau@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).