From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [V2 PATCH 7/8] pvh dom0: Add and remove foreign
	pages
Date: Mon, 25 Nov 2013 16:32:00 -0800
Message-ID: <20131125163200.1214facf@mantra.us.oracle.com>
References: <1385165018-25933-1-git-send-email-mukesh.rathor@oracle.com>
	<1385165018-25933-8-git-send-email-mukesh.rathor@oracle.com>
	<52932080020000780010665A@nat28.tlf.novell.com>
	<52939E53.9040009@tycho.nsa.gov>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <mukesh.rathor@oracle.com>) id 1Vl6ZX-0007vx-Ki
	for xen-devel@lists.xenproject.org; Tue, 26 Nov 2013 00:32:11 +0000
In-Reply-To: <52939E53.9040009@tycho.nsa.gov>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: xen-devel <xen-devel@lists.xenproject.org>, keir.xen@gmail.com, tim@xen.org, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 25 Nov 2013 14:00:35 -0500
Daniel De Graaf <dgdegra@tycho.nsa.gov> wrote:

> On 11/25/2013 04:03 AM, Jan Beulich wrote:
> >>>> On 23.11.13 at 01:03, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>>> wrote:
> >> +static int xenmem_add_foreign_to_pmap(unsigned long fgfn,
> >> unsigned long gpfn,
> >> +                                      domid_t foreign_domid)
> >> +{
> >> +    p2m_type_t p2mt, p2mt_prev;
> >> +    int rc = 0;
> >> +    unsigned long prev_mfn, mfn = 0;
> >> +    struct domain *fdom, *currd = current->domain;
> >> +    struct page_info *page = NULL;
> >> +
> >> +    if ( currd->domain_id == foreign_domid || foreign_domid ==
> >> DOMID_SELF ||
> >> +         !is_pvh_domain(currd) )
> >> +        return -EINVAL;
> >> +
> >> +    if ( !is_control_domain(currd) ||
> >> +         (fdom = get_pg_owner(foreign_domid)) == NULL )
> >> +        return -EPERM;
> >
> > Is this the right approach (i.e. shouldn't this be an XSM call)?
> > Cc-ing Daniel...
> >
> 
> Yes, this should be an XSM call; it needs to explicitly check if currd
> has the right to access pages from fdom.

I thought the control_domain would always have right to access pages
from fdoms. If no, can you please give some hints on which
xsm call I need to use. Glancing at xsm file, I can't figure quickly....

thanks
mukesh