From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 03/16] tmem: cleanup: rm unused tmem_op Date: Mon, 25 Nov 2013 11:37:26 -0500 Message-ID: <20131125163726.GA7133@phenom.dumpdata.com> References: <1384937185-24749-1-git-send-email-bob.liu@oracle.com> <1384937185-24749-3-git-send-email-bob.liu@oracle.com> <20131122173842.GA8120@phenom.dumpdata.com> <529329DF02000078001066E6@nat28.tlf.novell.com> <1385373136.11161.11.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VkzAE-0004eT-J5 for xen-devel@lists.xenproject.org; Mon, 25 Nov 2013 16:37:34 +0000 Content-Disposition: inline In-Reply-To: <1385373136.11161.11.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Bob Liu , keir@xen.org, Jan Beulich List-Id: xen-devel@lists.xenproject.org On Mon, Nov 25, 2013 at 09:52:16AM +0000, Ian Campbell wrote: > On Mon, 2013-11-25 at 09:43 +0000, Jan Beulich wrote: > > >>> On 22.11.13 at 18:38, Konrad Rzeszutek Wilk wrote: > > > On Wed, Nov 20, 2013 at 04:46:12PM +0800, Bob Liu wrote: > > >> TMEM_READ/TMEM_WRITE/TMEM_XCHG/TMEM_NEW_PAGE are never be used. > > > > > > You also need to delete them in include/public/tmem.h and rev up the > > > TMEM_SPEC_VERSION I think? > > > > I said this elsewhere already - you can't simply delete things > > from the public interface. > > Should 006a687ba4de74d7933c09b43872abc19f126c63 be partially reverted > then, to reinstate the typedef under a suitable #ifdef > __XEN_INTERFACE_VERSION__ ? I think that is OK - the typedef was of 'tmem_cli_mfn_t' which was 'xen_pfn_t' based. And the struct that got changed is now using 'xen_pfn_t' instead of 'tmem_cli_mfn_t'. > > Ian. >