xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel List <xen-devel@lists.xen.org>
Subject: Re: Coverity issues from 27/11/2013
Date: Wed, 27 Nov 2013 09:31:20 -0500	[thread overview]
Message-ID: <20131127143120.GE4430@pegasus.dumpdata.com> (raw)
In-Reply-To: <5295EDA5.4060509@citrix.com>

On Wed, Nov 27, 2013 at 01:03:33PM +0000, Andrew Cooper wrote:
> A very good Coverity run today.  30 issues fixed and only 2 introduced.

Woot!
> 
> The two introduced were not directly as a result of recent changes, but
> as a result of the tmem improvements.  Coverity tags an issue with types
> and names, so refactored code gets new issues tagged against it.
> 
> 
> The two 'new' issues are both to do with:
> 
> static inline void tmem_copy_to_client_buf_offset(tmem_cli_va_param_t clibuf,
> 
>                                                   int off,
>                                                   char *tmembuf, int len)
> {
>     copy_to_guest_offset(clibuf,off,tmembuf,len);
> }
> 
> Which throws away important errors which should not be ignored.

That had been there before (this CID).
> 
> I guess this is more something which needs considering when doing
> functional improvements to the tmem code.

One of the patches that Bob posted fixes this (by eliminating the
user of this inline function). I am waiting for those to be respun.
And then I will post an GIT PULL to pull them in.

It will be after Thanksgiving.
> 
> ~Andrew

      reply	other threads:[~2013-11-27 14:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 13:03 Coverity issues from 27/11/2013 Andrew Cooper
2013-11-27 14:31 ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131127143120.GE4430@pegasus.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).