From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Rathor Subject: Re: [V3 PATCH 5/9] PVH dom0: implement XENMEM_add_to_physmap_range for x86 Date: Mon, 2 Dec 2013 16:05:12 -0800 Message-ID: <20131202160512.66d321d0@mantra.us.oracle.com> References: <1385519230-21132-1-git-send-email-mukesh.rathor@oracle.com> <1385519230-21132-6-git-send-email-mukesh.rathor@oracle.com> <529C8F6D0200007800108B8E@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VndVN-0000F2-BT for xen-devel@lists.xenproject.org; Tue, 03 Dec 2013 00:06:21 +0000 In-Reply-To: <529C8F6D0200007800108B8E@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: george.dunlap@eu.citrix.com, xen-devel , keir.xen@gmail.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 02 Dec 2013 12:47:25 +0000 "Jan Beulich" wrote: > >>> On 27.11.13 at 03:27, Mukesh Rathor > >>> wrote: > > This preparatory patch adds support for XENMEM_add_to_physmap_range > > on x86 so it can be used to create a guest on PVH dom0. To this > > end, we add a new function xenmem_add_to_physmap_range(), and change > > xenmem_add_to_physmap_once parameters so it can be called from > > xenmem_add_to_physmap_range. > > > > Please note, compat will continue to return -ENOSYS. > > And as noted a number of times before - I don't think that's > appropriate. There's nothing keeping non-PVH guests from using > this interface, and hence it should either be uniformly available to > all of them, or uniformly unavailable. I'm not intending to apply > such a half baked thing. I am sorry for your frustration, but as I said before, doing it is not straightforward as it involves creating a new version of XLAT_add_to_physmap which unfortunately is generated via python/shell scripts. At this point, I want to focus on the 64bit. I understand while it's not a regression, it's a partial implementation, but so is the entire PVH and many other features that are "work in progress". Your final word on this was: quote: Then leave it out, and I'll waste my time on getting it implemented once the patch set is in. But please add a clear note of this state to the patch description. Jan end quote All your other comments are taken care of. Thanks for your help. mukesh