From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [V5 PATCH 6/7] pvh dom0: Add and remove foreign
 pages
Date: Thu, 5 Dec 2013 17:39:56 -0800
Message-ID: <20131205173956.2af5b1ec@mantra.us.oracle.com>
References: <1386209128-5261-1-git-send-email-mukesh.rathor@oracle.com>
	<1386209128-5261-7-git-send-email-mukesh.rathor@oracle.com>
	<52A075F1.40502@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <52A075F1.40502@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: Xen-devel@lists.xensource.com, Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, tim@xen.org, keir.xen@gmail.com, JBeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

On Thu, 05 Dec 2013 12:47:45 +0000
Julien Grall <julien.grall@linaro.org> wrote:

> On 12/05/2013 02:05 AM, Mukesh Rathor wrote:
> > In this patch, a new function, xenmem_add_foreign_to_p2m(), is added

..........

> > +#endif
> 
> Here, you can reduce the CONFIG_X86 something like that
> 
> else
> {
> 	stuct domain *foreign_dom;
> #ifdef CONFIG_x86
> 	p2m_type_t tp;
> 	mfn = mfn_x(get_gfn_query(d, xrfp.gpfn, &tp);
>          ASSERT(is_pvh_domain(d));
>          ASSERT(p2m_is_forein(tp));
> #else
> 	mfn = gmfn_to_mfn(d, xrfp.gpfn);
> #endif
>          foreign_dom = page_get_owner(mfn_to_page(mfn));
>          ASSERT(d != foreign_dom);
> }
> 
> Until p2m_is_foreign(_t) is correctly setup on ARM,
> remove_from_physmap in ARM will never go to the else part, so it's
> fine.

Again, the change is totally irrelevant to the patch objective, and would
be confusing to someone. Let's add it as a patch with explanation
after this goes in. Meanwhile, everything will remain the same on ARM
after this patch.

thanks
mukesh