From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Bob Liu <lliubbo@gmail.com>,
keir@xen.org, ian.campbell@citrix.com
Subject: Re: [PATCH v2 01/16] tmem: fix public head file
Date: Fri, 6 Dec 2013 09:36:39 -0500 [thread overview]
Message-ID: <20131206143639.GH3096@pegasus.dumpdata.com> (raw)
In-Reply-To: <52A1AEEC020000780010AC91@nat28.tlf.novell.com>
On Fri, Dec 06, 2013 at 10:03:08AM +0000, Jan Beulich wrote:
> >>> On 03.12.13 at 03:19, Bob Liu <lliubbo@gmail.com> wrote:
> > Commit 006a687ba4de74d7933c09b43872abc19f126c63 dropped typedef
> > tmem_cli_mfn_t
> > from public tmem.h which may cause some problem.
> > This patch added tmem_cli_mfn_t back with #ifdef __XEN_INTERFACE_VERSION__
> > around.
> >
> > Signed-off-by: Bob Liu <bob.liu@oracle.com>
>
> Konrad,
>
> any chance of you ack-ing at least this one, so we can get the public
> header in proper shape again for 4.4?
Yes. Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
If you would like to take this straight away, please do!
>
> Jan
>
> > ---
> > xen/include/public/tmem.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/xen/include/public/tmem.h b/xen/include/public/tmem.h
> > index dd685ee..5eb2fb4 100644
> > --- a/xen/include/public/tmem.h
> > +++ b/xen/include/public/tmem.h
> > @@ -95,6 +95,9 @@
> >
> >
> > #ifndef __ASSEMBLY__
> > +#if __XEN_INTERFACE_VERSION__ < 0x00040400
> > +typedef xen_pfn_t tmem_cli_mfn_t;
> > +#endif
> > typedef XEN_GUEST_HANDLE(char) tmem_cli_va_t;
> > struct tmem_op {
> > uint32_t cmd;
> > --
> > 1.7.10.4
>
>
>
next prev parent reply other threads:[~2013-12-06 14:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 2:19 [PATCH v2 00/16] tmem: continue to cleanup tmem Bob Liu
2013-12-03 2:19 ` [PATCH v2 01/16] tmem: fix public head file Bob Liu
2013-12-06 10:03 ` Jan Beulich
2013-12-06 14:36 ` Konrad Rzeszutek Wilk [this message]
2013-12-03 2:19 ` [PATCH v2 02/16] tmem: cleanup: drop unused sub command Bob Liu
2013-12-03 2:19 ` [PATCH v2 03/16] tmem: cleanup: drop some debug code Bob Liu
2013-12-03 2:19 ` [PATCH v2 04/16] tmem: cleanup: drop useless function 'tmem_copy_page' Bob Liu
2013-12-03 2:19 ` [PATCH v2 05/16] tmem: cleanup: drop useless parameters from put/get page Bob Liu
2013-12-03 2:19 ` [PATCH v2 06/16] tmem: cleanup: reorg function do_tmem_put() Bob Liu
2013-12-03 2:19 ` [PATCH v2 07/16] tmem: drop unneeded is_ephemeral() and is_private() Bob Liu
2013-12-03 2:19 ` [PATCH v2 08/16] tmem: cleanup: rm useless EXPORT/FORWARD define Bob Liu
2013-12-03 2:19 ` [PATCH v2 09/16] tmem: cleanup: drop runtime statistics Bob Liu
2013-12-03 2:19 ` [PATCH v2 10/16] tmem: cleanup: drop tmem_lock_all Bob Liu
2013-12-03 2:19 ` [PATCH v2 11/16] tmem: cleanup: refactor the alloc/free path Bob Liu
2013-12-03 2:19 ` [PATCH v2 12/16] tmem: cleanup: __tmem_alloc_page: drop unneed parameters Bob Liu
2013-12-03 2:19 ` [PATCH v2 13/16] tmem: cleanup: drop useless functions from head file Bob Liu
2013-12-03 10:32 ` Andrew Cooper
2013-12-06 6:53 ` Bob Liu
2013-12-03 2:19 ` [PATCH v2 14/16] tmem: refator function tmem_ensure_avail_pages() Bob Liu
2013-12-03 2:19 ` [PATCH v2 15/16] tmem: cleanup: rename tmem_relinquish_npages() Bob Liu
2013-12-03 2:19 ` [PATCH v2 16/16] tmem: cleanup: rm unused tmem_freeze_all() Bob Liu
2013-12-03 21:07 ` [PATCH v2 00/16] tmem: continue to cleanup tmem Konrad Rzeszutek Wilk
2013-12-03 21:50 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206143639.GH3096@pegasus.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=lliubbo@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).