From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v2 01/16] tmem: fix public head file
Date: Fri, 6 Dec 2013 09:36:39 -0500
Message-ID: <20131206143639.GH3096@pegasus.dumpdata.com>
References: <1386037157-27261-1-git-send-email-bob.liu@oracle.com>
	<1386037157-27261-2-git-send-email-bob.liu@oracle.com>
	<52A1AEEC020000780010AC91@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <konrad.wilk@oracle.com>) id 1VowWQ-00087E-OB
	for xen-devel@lists.xenproject.org; Fri, 06 Dec 2013 14:36:50 +0000
Content-Disposition: inline
In-Reply-To: <52A1AEEC020000780010AC91@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Bob Liu <lliubbo@gmail.com>, keir@xen.org, ian.campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Fri, Dec 06, 2013 at 10:03:08AM +0000, Jan Beulich wrote:
> >>> On 03.12.13 at 03:19, Bob Liu <lliubbo@gmail.com> wrote:
> > Commit 006a687ba4de74d7933c09b43872abc19f126c63 dropped typedef 
> > tmem_cli_mfn_t
> > from public tmem.h which may cause some problem.
> > This patch added tmem_cli_mfn_t back with #ifdef __XEN_INTERFACE_VERSION__
> > around.
> > 
> > Signed-off-by: Bob Liu <bob.liu@oracle.com>
> 
> Konrad,
> 
> any chance of you ack-ing at least this one, so we can get the public
> header in proper shape again for 4.4?

Yes. Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

If you would like to take this straight away, please do!

> 
> Jan
> 
> > ---
> >  xen/include/public/tmem.h |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/xen/include/public/tmem.h b/xen/include/public/tmem.h
> > index dd685ee..5eb2fb4 100644
> > --- a/xen/include/public/tmem.h
> > +++ b/xen/include/public/tmem.h
> > @@ -95,6 +95,9 @@
> >  
> >  
> >  #ifndef __ASSEMBLY__
> > +#if __XEN_INTERFACE_VERSION__ < 0x00040400
> > +typedef xen_pfn_t tmem_cli_mfn_t;
> > +#endif
> >  typedef XEN_GUEST_HANDLE(char) tmem_cli_va_t;
> >  struct tmem_op {
> >      uint32_t cmd;
> > -- 
> > 1.7.10.4
> 
> 
>