From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
ian.campbell@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH RFC 3/5] Introduce ts-ovmf-debian-install
Date: Tue, 10 Dec 2013 17:36:25 +0000 [thread overview]
Message-ID: <20131210173625.GN32155@zion.uk.xensource.com> (raw)
In-Reply-To: <21159.20448.487185.402092@mariner.uk.xensource.com>
On Tue, Dec 10, 2013 at 05:31:12PM +0000, Ian Jackson wrote:
> Ian Jackson writes ("Re: [PATCH RFC 3/5] Introduce ts-ovmf-debian-install"):
> > Wei Liu writes ("[PATCH RFC 3/5] Introduce ts-ovmf-debian-install"):
> > > This is OVMF guest test case. It resembles ts-redhat-install:
> > > 1. prepare a auto install CD
> > > 2. install OVMF guest
> > > 3. test if the guets is up
> >
> > This seems to duplicate an awful lot of the preseed generation from
> > Osstest::Debian::preseed_create.
> >
> > I'm afraid you'll need to refactor this to remove the duplication.
> > This might well involve a code-motion-only pre-patch.
>
> Also, how much does this differ from a hypothetical
> ts-debian-hvm-install ?
>
1. preseed files are different
2. vanilla debian hvm installation won't need to manipulate ISO
> Perhaps the answer is to have a ts-debian-hvm-install and control the
> use of ovmf with a runvar.
>
Are those two easy to implement with runvars?
Wei.
> Ian.
next prev parent reply other threads:[~2013-12-10 17:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 17:19 [PATCH RFC 0/5] OSSTest: OVMF guest test case Wei Liu
2013-12-10 17:19 ` [PATCH RFC 1/5] TestSupport.pm: add bios option to guest config file Wei Liu
2013-12-10 17:23 ` Ian Jackson
2013-12-10 17:19 ` [PATCH RFC 2/5] Build OVMF for Xen-unstable Wei Liu
2013-12-10 17:24 ` Ian Jackson
2013-12-10 17:24 ` Ian Jackson
2013-12-10 17:26 ` Ian Jackson
2013-12-10 17:38 ` Wei Liu
2013-12-10 17:47 ` Ian Campbell
2013-12-10 19:31 ` Ian Jackson
2013-12-11 10:29 ` Ian Campbell
2013-12-10 19:29 ` Ian Jackson
2013-12-10 17:19 ` [PATCH RFC 3/5] Introduce ts-ovmf-debian-install Wei Liu
2013-12-10 17:30 ` Ian Jackson
2013-12-10 17:31 ` Ian Jackson
2013-12-10 17:36 ` Wei Liu [this message]
2013-12-10 17:41 ` Wei Liu
2013-12-10 17:19 ` [PATCH RFC 4/5] make-flight: OVMF test filght Wei Liu
2013-12-10 17:34 ` Wei Liu
2013-12-10 17:19 ` [PATCH RFC 5/5] sg-run-job: OVMF job Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210173625.GN32155@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).