From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Bob Liu <bob.liu@oracle.com>
Cc: james.harper@bendigoit.com.au, ian.campbell@citrix.com,
Andrew Cooper <andrew.cooper3@citrix.com>,
Bob Liu <lliubbo@gmail.com>,
JBeulich@suse.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 09/15] tmem: cleanup: drop tmem_lock_all
Date: Wed, 11 Dec 2013 17:01:15 -0500 [thread overview]
Message-ID: <20131211220115.GB9754@phenom.dumpdata.com> (raw)
In-Reply-To: <52A86492.9060201@oracle.com>
On Wed, Dec 11, 2013 at 09:11:46PM +0800, Bob Liu wrote:
>
> On 12/11/2013 06:45 PM, Andrew Cooper wrote:
> > On 11/12/13 08:50, Bob Liu wrote:
> >> tmem_lock_all is used for debug only, remove it from upstream to make
> >> tmem source code more readable and easier to maintain.
> >> And no_evict is meaningless without tmem_lock_all, this patch removes it
> >> also.
> >>
> >> Signed-off-by: Bob Liu <bob.liu@oracle.com>
> >
> > This should probably be tagged with Coverity ID 1055654 which is a
> > locking order reversal between tmem_spinlock and the heap_lock.
> >
>
> Then it would be better if it gets merged into 4.4.
> By the way where I can find the full CIDs descriptions?
I can put that in the commit.
>
> I remember your mentioned another issue.
> ------------------------------------
> The two 'new' issues are both to do with:
>
> static inline void tmem_copy_to_client_buf_offset(tmem_cli_va_param_t
> clibuf, int off, char *tmembuf, int len)
> {
> copy_to_guest_offset(clibuf,off,tmembuf,len);
> }
>
> Which throws away important errors which should not be ignored.
> -----------------------------------
>
> One of my patches can fix it also.
Excellent!
>
> > I certainly think this is an appropriate fix.
> >
>
> So I'll separate patches which are suitable for 4.4 from this patchset
> and resend them with CIDs in the commit message.
OK, just reply to the patchset so I can pick the modified version.
>
> Thanks,
> -Bod
next prev parent reply other threads:[~2013-12-11 22:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 8:50 [PATCH v3 00/15] tmem: continue to cleanup tmem Bob Liu
2013-12-11 8:50 ` [PATCH v3 01/15] tmem: cleanup: drop unused sub command Bob Liu
2013-12-11 8:50 ` [PATCH v3 02/15] tmem: cleanup: drop some debug code Bob Liu
2013-12-11 8:50 ` [PATCH v3 03/15] tmem: cleanup: drop useless function 'tmem_copy_page' Bob Liu
2013-12-11 8:50 ` [PATCH v3 04/15] tmem: cleanup: drop useless parameters from put/get page Bob Liu
2013-12-11 8:50 ` [PATCH v3 05/15] tmem: cleanup: reorg function do_tmem_put() Bob Liu
2013-12-11 8:50 ` [PATCH v3 06/15] tmem: drop unneeded is_ephemeral() and is_private() Bob Liu
2013-12-11 8:50 ` [PATCH v3 07/15] tmem: cleanup: rm useless EXPORT/FORWARD define Bob Liu
2013-12-11 8:50 ` [PATCH v3 08/15] tmem: cleanup: drop runtime statistics Bob Liu
2013-12-11 8:50 ` [PATCH v3 09/15] tmem: cleanup: drop tmem_lock_all Bob Liu
2013-12-11 10:45 ` Andrew Cooper
2013-12-11 13:11 ` Bob Liu
2013-12-11 22:01 ` Konrad Rzeszutek Wilk [this message]
2013-12-11 8:50 ` [PATCH v3 10/15] tmem: cleanup: refactor the alloc/free path Bob Liu
2013-12-11 8:50 ` [PATCH v3 11/15] tmem: cleanup: __tmem_alloc_page: drop unneed parameters Bob Liu
2013-12-11 8:50 ` [PATCH v3 12/15] tmem: cleanup: drop useless functions from head file Bob Liu
2013-12-11 8:50 ` [PATCH v3 13/15] tmem: refator function tmem_ensure_avail_pages() Bob Liu
2013-12-11 8:50 ` [PATCH v3 14/15] tmem: cleanup: rename tmem_relinquish_npages() Bob Liu
2013-12-11 8:50 ` [PATCH v3 15/15] tmem: cleanup: rm unused tmem_freeze_all() Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211220115.GB9754@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=bob.liu@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=james.harper@bendigoit.com.au \
--cc=lliubbo@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).