From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v3 09/15] tmem: cleanup: drop tmem_lock_all Date: Wed, 11 Dec 2013 17:01:15 -0500 Message-ID: <20131211220115.GB9754@phenom.dumpdata.com> References: <1386751844-32387-1-git-send-email-bob.liu@oracle.com> <1386751844-32387-10-git-send-email-bob.liu@oracle.com> <52A8425A.4070609@citrix.com> <52A86492.9060201@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Vqrqg-0005Aq-MD for xen-devel@lists.xenproject.org; Wed, 11 Dec 2013 22:01:42 +0000 Content-Disposition: inline In-Reply-To: <52A86492.9060201@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Bob Liu Cc: james.harper@bendigoit.com.au, ian.campbell@citrix.com, Andrew Cooper , Bob Liu , JBeulich@suse.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Wed, Dec 11, 2013 at 09:11:46PM +0800, Bob Liu wrote: > > On 12/11/2013 06:45 PM, Andrew Cooper wrote: > > On 11/12/13 08:50, Bob Liu wrote: > >> tmem_lock_all is used for debug only, remove it from upstream to make > >> tmem source code more readable and easier to maintain. > >> And no_evict is meaningless without tmem_lock_all, this patch removes it > >> also. > >> > >> Signed-off-by: Bob Liu > > > > This should probably be tagged with Coverity ID 1055654 which is a > > locking order reversal between tmem_spinlock and the heap_lock. > > > > Then it would be better if it gets merged into 4.4. > By the way where I can find the full CIDs descriptions? I can put that in the commit. > > I remember your mentioned another issue. > ------------------------------------ > The two 'new' issues are both to do with: > > static inline void tmem_copy_to_client_buf_offset(tmem_cli_va_param_t > clibuf, int off, char *tmembuf, int len) > { > copy_to_guest_offset(clibuf,off,tmembuf,len); > } > > Which throws away important errors which should not be ignored. > ----------------------------------- > > One of my patches can fix it also. Excellent! > > > I certainly think this is an appropriate fix. > > > > So I'll separate patches which are suitable for 4.4 from this patchset > and resend them with CIDs in the commit message. OK, just reply to the patchset so I can pick the modified version. > > Thanks, > -Bod