From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [RFC PATCH v3 19/19] smp, x86: kill SMP single function call interrupt Date: Wed, 11 Dec 2013 23:10:11 +0100 Message-ID: <20131211221011.GA26423@breakpoint.cc> References: <1386173591-28514-1-git-send-email-liuj97@gmail.com> <1386173591-28514-20-git-send-email-liuj97@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1386173591-28514-20-git-send-email-liuj97@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jiang Liu Cc: Jeremy Fitzhardinge , Gleb Natapov , Peter Zijlstra , Wang YanQing , "H. Peter Anvin" , Thomas Gleixner , linux-arch@vger.kernel.org, Andi Kleen , Joerg Roedel , x86@kernel.org, Ingo Molnar , Yang Zhang , xen-devel@lists.xenproject.org, Ingo Molnar , Shaohua Li , Peter Zijlstra , Konrad Rzeszutek Wilk , Steven Rostedt , xen-devel@lists.xensource.com, Al Viro , Jiri Kosina , Boris Ostrovsky , virtualization@lists.linux-foundation.org, Seiji Aguchi , linux-kernel@vger.kernel.org, David List-Id: xen-devel@lists.xenproject.org On 05.12.13, Jiang Liu wrote: I like this in general however > diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c > index 7cf1689..f241792 100644 > --- a/arch/x86/xen/smp.c > +++ b/arch/x86/xen/smp.c > @@ -560,7 +560,6 @@ static inline int xen_map_vector(int vector) > xen_vector = XEN_RESCHEDULE_VECTOR; > break; > case CALL_FUNCTION_VECTOR: > - case CALL_FUNCTION_SINGLE_VECTOR: > xen_vector = XEN_CALL_FUNCTION_VECTOR; > break; > case IRQ_WORK_VECTOR: This chunk does not apply again tip's master branch, the code looks different. You need to also kill XEN_CALL_FUNCTION_SINGLE_VECTOR which is either part of a different patch or against a different tree. I haven't seen a note in 0/19 or this patch description so I'm confused here :) Sebastian