Re: [PATCH RFC V2 4/6] Introduce ts-ovmf-debian-install

[Wei Liu <wei.liu2@citrix.com>]

On Thu, Dec 12, 2013 at 09:49:11AM +0100, Dario Faggioli wrote:
> On mer, 2013-12-11 at 16:11 +0000, Wei Liu wrote:
> > diff --git a/ts-ovmf-debian-install b/ts-ovmf-debian-install
> > new file mode 100755
> > index 0000000..2e19348
> > --- /dev/null
> > +++ b/ts-ovmf-debian-install
> 
> > +sub start () {
> > +    target_cmd_root($ho, "$xl create $gho->{CfgPath}", 100);
> > +}
> > +
> Something like "toolstack()->{Command}" instead of "xl" ?
> 

$xl is in fact toolstack()->{Command}.

> I don't know how important this is, though, as I don't think this has
> much chances to work with xend, has it?
> 

No. Xend is deprecated so I don't bother fiddling with that.

However this doesn't prevent people using Xend from using OVMF. It's
just firmware after all.

> > +rewrite_config_nocd();
> > +start();
> > +guest_await_dhcp_tcp($gho,300);
> > +guest_check_up($gho);
> >
> Does this mean that the guest remains up after the end of the test? This
> is also probably not a big deal, but, shouldn't we tear it down?
> 

I copied this from ts-redhat-install.

My guess would be we might need to check if there's anything wrong with
DomU, especially when test fails. Destroying DomU will wipe out useful
information.

Wei.

> Regards,
> Dario
> 
> -- 
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
>