From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH RFC V2 4/6] Introduce ts-ovmf-debian-install
Date: Thu, 12 Dec 2013 12:29:12 +0000
Message-ID: <20131212122912.GB21900@zion.uk.xensource.com>
References: <1386778305-29995-1-git-send-email-wei.liu2@citrix.com>
	<1386778305-29995-5-git-send-email-wei.liu2@citrix.com>
	<1386838151.5488.90.camel@Solace>
	<20131212121622.GA21900@zion.uk.xensource.com>
	<1386851059.5488.102.camel@Solace>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1386851059.5488.102.camel@Solace>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: ian.jackson@eu.citrix.com, Wei Liu <wei.liu2@citrix.com>, ian.campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, Dec 12, 2013 at 01:24:19PM +0100, Dario Faggioli wrote:
> On gio, 2013-12-12 at 12:16 +0000, Wei Liu wrote:
> > On Thu, Dec 12, 2013 at 09:49:11AM +0100, Dario Faggioli wrote:
> > > On mer, 2013-12-11 at 16:11 +0000, Wei Liu wrote:
> > > > diff --git a/ts-ovmf-debian-install b/ts-ovmf-debian-install
> > > > new file mode 100755
> > > > index 0000000..2e19348
> > > > --- /dev/null
> > > > +++ b/ts-ovmf-debian-install
> > > 
> > > > +sub start () {
> > > > +    target_cmd_root($ho, "$xl create $gho->{CfgPath}", 100);
> > > > +}
> > > > +
> > > Something like "toolstack()->{Command}" instead of "xl" ?
> > > 
> > 
> > $xl is in fact toolstack()->{Command}.
> > 
> I know.
> 
> > > I don't know how important this is, though, as I don't think this has
> > > much chances to work with xend, has it?
> > > 
> > 
> > No. Xend is deprecated so I don't bother fiddling with that.
> > 
> Ok. I was also thinking that keeping these things general and abstract
> enough would be better if, at some point, we'd like to intdocude other
> toolstack (e.g., virsh/libvirt). However, changes will be needed anyway,
> e.g., to the "create" part... so, yeah, I guess this is a non issue.
> 

Correct. If we are to support more toolstack there's certainly more work
to do...

> > > Does this mean that the guest remains up after the end of the test? This
> > > is also probably not a big deal, but, shouldn't we tear it down?
> > > 
> > 
> > I copied this from ts-redhat-install.
> > 
> You're right, sorry for this. I thought I see gests being teared down
> somewhere, but just finished running a (similar) test myself, and the
> guest is up.
> 
> Sorry again for the noise. :-)
> 

Not at all. It's not noise. Thanks for reviewing.

Wei.

> Regards,
> Dario
> 
> -- 
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
>