From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up. Date: Thu, 12 Dec 2013 20:34:15 -0500 Message-ID: <20131213013415.GC2697@pegasus.dumpdata.com> References: <1386105246-14337-1-git-send-email-konrad.wilk@oracle.com> <1386149848.13256.86.camel@kazak.uk.xensource.com> <1386154783.17466.14.camel@kazak.uk.xensource.com> <1386155291.17466.19.camel@kazak.uk.xensource.com> <1386156220.17466.29.camel@kazak.uk.xensource.com> <20131211202657.GA5153@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VrHf2-0007RC-CQ for xen-devel@lists.xenproject.org; Fri, 13 Dec 2013 01:35:24 +0000 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, dmitry.torokhov@gmail.com, Ian Campbell , david.vrabel@citrix.com List-Id: xen-devel@lists.xenproject.org > > I think that the patch is good, the main issue is that it is missing the > ARM and ARM64 implementations of xen_has_pv_devices & co. I think that is OK - you don't have CONFIG_PVHVM so from the platform_pci.h the 'static inline' ones get picked up which will return true (except the xen_has_pv_block_and_legacy_devices which will return false) for all of those functions (if compiled with CONFIG_XEN). It should compile _and_ work properly. .. snip.. > __xen_has_pv_device should be static Yes. Thanks for spotting that! >