From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Wilson <msw@linux.com>
Subject: Re: [PATCH] Xend: handle died domain in getVCPUInfo()
Date: Sun, 15 Dec 2013 13:33:45 -0800
Message-ID: <20131215213343.GA993@u109add4315675089e695.ant.amazon.com>
References: <52A6D92F.6020600@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <52A6D92F.6020600@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Joe Jin <joe.jin@oracle.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Sureshmon Nair <sureshmon.nair@oracle.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel <xen-devel@lists.xen.org>, chuang cao <chuang.cao@oracle.com>, Matt Wilson <msw@amazon.com>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, Dec 10, 2013 at 05:04:47PM +0800, Joe Jin wrote:
> When created new guest on NUMA server, xend tried to get the best node
> by calculated all vcpus info, if domain already be terminated then
> getVCPUInfo() will throw below exception and guest start failed:
> 
> [2013-09-04 20:01:26 6254] ERROR (XendDomainInfo:496) VM start failed
> Traceback (most recent call last):
>   File "/usr/lib64/python2.4/site-packages/xen/xend/XendDomainInfo.py", line 482, in start
>     XendTask.log_progress(31, 60, self._initDomain)
>   File "/usr/lib64/python2.4/site-packages/xen/xend/XendTask.py", line 209, in log_progress
>     retval = func(*args, **kwds)
>   File "/usr/lib64/python2.4/site-packages/xen/xend/XendDomainInfo.py", line 2918, in _initDomain
>     node = self._setCPUAffinity()
>   File "/usr/lib64/python2.4/site-packages/xen/xend/XendDomainInfo.py", line 2835, in _setCPUAffinity
>     best_node = find_relaxed_node(candidate_node_list)[0]
>   File "/usr/lib64/python2.4/site-packages/xen/xend/XendDomainInfo.py", line 2803, in find_relaxed_node
>     cpuinfo = dom.getVCPUInfo()
>   File "/usr/lib64/python2.4/site-packages/xen/xend/XendDomainInfo.py", line 1600, in getVCPUInfo
>     raise XendError(str(exn))
> XendError: (3, 'No such process')
> 
> This patch will check return value of xc.vcpu_getinfo() and make sure the
> error not caused by domain died before throw the exception.
> 
> Signed-off-by: Joe Jin <joe.jin@oracle.com>

Acked-by: Matt Wilson <msw@amazon.com>

> Cc: Matt Wilson <msw@amazon.com>
> Cc: Keir Fraser <keir@xen.org>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Roger Pau Monne <roger.pau@citrix.com>
> ---
>  tools/python/xen/xend/XendDomainInfo.py |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/python/xen/xend/XendDomainInfo.py b/tools/python/xen/xend/XendDomainInfo.py
> index e9d3e7e..8d4ff5c 100644
> --- a/tools/python/xen/xend/XendDomainInfo.py
> +++ b/tools/python/xen/xend/XendDomainInfo.py
> @@ -35,8 +35,10 @@ import stat
>  import shutil
>  import traceback
>  from types import StringTypes
> +import errno
>  
>  import xen.lowlevel.xc
> +from xen.lowlevel.xc import Error as XCError
>  from xen.util import asserts, auxbin, mkdir
>  from xen.util.blkif import parse_uname
>  import xen.util.xsm.xsm as security
> @@ -1540,7 +1542,10 @@ class XendDomainInfo:
>  
>              return sxpr
>  
> -        except RuntimeError, exn:
> +        except XCError, exn:
> +            # Domain already died.
> +            if exn.args[0] == errno.ESRCH:
> +                return sxpr
>              raise XendError(str(exn))
>  
>