xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Adel Amani <adel.amani66@yahoo.com>
Cc: Xen <xen-devel@lists.xen.org>
Subject: Re: function snprintf() in xen_save_domain.c for debugged
Date: Wed, 5 Feb 2014 13:39:08 +0100	[thread overview]
Message-ID: <20140205123908.GA1198@aepfle.de> (raw)
In-Reply-To: <1391583040.24823.YahooMailNeo@web161802.mail.bf1.yahoo.com>

On Tue, Feb 04, Adel Amani wrote:

>     si.flags = atoi(argv[5]);

> lvl = si.flags & XCFLAGS_DEBUG ? XTL_DEBUG: XTL_DETAIL;
> lflags = XTL_STDIOSTREAM_SHOW_PID | XTL_STDIOSTREAM_HIDE_PROGRESS;
> l = (xentoollog_logger *)xtl_createlogger_stdiostream(stderr, lvl, lflags);
> si.xch = xc_interface_open(l,0,0);

Please check what XCFLAGS_DEBUG actually means, and if that condition
can ever be true without modifying also xend related code.

I guess in your exploration of how migration internally actually works
it would be easier for you to just write 'lvl = XTL_DEBUG;' and be done
with it.

Other than that, the changes you made appear to be correct.

Olaf

  reply	other threads:[~2014-02-05 12:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-02  8:51 function snprintf() in xen_save_domain.c for debugged Adel Amani
2014-02-02 10:00 ` Olaf Hering
2014-02-03 12:56   ` Adel Amani
2014-02-03 13:11     ` Olaf Hering
2014-02-05  6:50       ` Adel Amani
2014-02-05 12:39         ` Olaf Hering [this message]
2014-02-06 12:28           ` Adel Amani
2014-02-06 21:40             ` Olaf Hering
     [not found]               ` <1391807749.53657.YahooMailNeo@web161801.mail.bf1.yahoo.com>
2014-02-07 22:22                 ` Olaf Hering
     [not found]                   ` <1392796739.73315.YahooMailNeo@web161801.mail.bf1.yahoo.com>
2014-02-19 14:12                     ` Olaf Hering
2014-02-21  7:18                       ` Adel Amani
2014-02-21  9:30                         ` Olaf Hering
2014-02-21 16:34                           ` Adel Amani
2014-02-24  9:02                             ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140205123908.GA1198@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=adel.amani66@yahoo.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).