From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] linux-2.6.18/xencons: generalize use of add_preferred_console() Date: Thu, 6 Feb 2014 23:53:34 +0100 Message-ID: <20140206225334.GA21743@aepfle.de> References: <52AAE1C2020000780010CE39@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WBXpG-0008BL-LA for xen-devel@lists.xenproject.org; Thu, 06 Feb 2014 22:53:42 +0000 Content-Disposition: inline In-Reply-To: <52AAE1C2020000780010CE39@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Fri, Dec 13, Jan Beulich wrote: > Changeset 762:a070228ac76e ("add hvc compatibility mode to xencons" > added this call just for the HVC case, without giving any reason why > HVC would be special in this regard. Use the call for all cases. > +++ b/drivers/xen/console/console.c > @@ -236,6 +234,8 @@ static int __init xen_console_init(void) > > wbuf = alloc_bootmem(wbuf_size); > > + if (!is_initial_xendomain()) > + add_preferred_console(kcons_info.name, xc_num, NULL); > register_console(&kcons_info); Why is dom0 special in this case anyway? At least with SLE12, when Xen is booted with 'console=com1 com1=115200' and the kernel is booted without any console= or xencons=, kcons_info.index is still -1 and as a result xvc-1 is registered as name for xvc0. This confuses systemd because kernel name and console name do not match, so login via serial is not possible. When add_preferred_console is called uncondtionally the login on serial works as expected. Olaf