[BUG]Cannot build mini-os-x86_64-c

[BUG]Cannot build mini-os-x86_64-c

[Masaki Muranaka]

[-- Attachment #1.1: Type: text/plain, Size: 785 bytes --]

Hello,

I got the build error. Log is like this:
/home/azureuser/xen/stubdom/mini-os-x86_64-c/test.o: In function `app_main':
/home/azureuser/xen/extras/mini-os/test.c:542: multiple definition of
`app_main'
/home/azureuser/xen/stubdom/mini-os-x86_64-c/main.o:/home/azureuser/xen/extras/mini-os/main.c:187:
first defined here
make[1]: *** [/home/azureuser/xen/stubdom/mini-os-x86_64-c/mini-os] Error 1
make[1]: Leaving directory `/home/azureuser/xen/extras/mini-os'
make: *** [c-stubdom] Error 2


I thinks stubdom/c/minios.cfg should be like this.

diff --git a/stubdom/c/minios.cfg b/stubdom/c/minios.cfg
index e1faee5..f2a3178 100644
--- a/stubdom/c/minios.cfg
+++ b/stubdom/c/minios.cfg
@@ -1 +1 @@
-CONFIG_TEST=y
+CONFIG_TEST=n


Thanks,

-- 
Masaki Muranaka
Monami-ya LLC, Japan.

[-- Attachment #1.2: Type: text/html, Size: 1146 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [BUG]Cannot build mini-os-x86_64-c

[Ian Campbell]

On Sat, 2014-02-01 at 17:55 +0900, Masaki Muranaka wrote:
> Hello,
> 
> 
> I got the build error. Log is like this:
> /home/azureuser/xen/stubdom/mini-os-x86_64-c/test.o: In function
> `app_main':
> 
> /home/azureuser/xen/extras/mini-os/test.c:542: multiple definition of
> `app_main'
> /home/azureuser/xen/stubdom/mini-os-x86_64-c/main.o:/home/azureuser/xen/extras/mini-os/main.c:187: first defined here
> make[1]: *** [/home/azureuser/xen/stubdom/mini-os-x86_64-c/mini-os]
> Error 1
> make[1]: Leaving directory `/home/azureuser/xen/extras/mini-os'
> make: *** [c-stubdom] Error 2
> 
> 
> 
> 
> I thinks stubdom/c/minios.cfg should be like this.

That sounds plausible. I'm not sure what would then include the tests at
that point though.

If Samuel agrees with the patch please could you formally submit
according to http://wiki.xen.org/wiki/Submitting_Xen_Patches



> 
> 
> diff --git a/stubdom/c/minios.cfg b/stubdom/c/minios.cfg
> index e1faee5..f2a3178 100644
> --- a/stubdom/c/minios.cfg
> +++ b/stubdom/c/minios.cfg
> @@ -1 +1 @@
> -CONFIG_TEST=y
> +CONFIG_TEST=n
> 
> 
> 
> 
> Thanks,
> 
> 
> -- 
> Masaki Muranaka
> Monami-ya LLC, Japan.
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Re: [BUG]Cannot build mini-os-x86_64-c

[Samuel Thibault]

Ian Campbell, le Mon 03 Feb 2014 10:28:07 +0000, a écrit :
> On Sat, 2014-02-01 at 17:55 +0900, Masaki Muranaka wrote:
> > I got the build error. Log is like this:
> > /home/azureuser/xen/stubdom/mini-os-x86_64-c/test.o: In function
> > `app_main':
> > 
> > /home/azureuser/xen/extras/mini-os/test.c:542: multiple definition of
> > `app_main'
> > /home/azureuser/xen/stubdom/mini-os-x86_64-c/main.o:/home/azureuser/xen/extras/mini-os/main.c:187: first defined here
> > make[1]: *** [/home/azureuser/xen/stubdom/mini-os-x86_64-c/mini-os]
> > Error 1
> > make[1]: Leaving directory `/home/azureuser/xen/extras/mini-os'
> > make: *** [c-stubdom] Error 2
> > 
> > 
> > 
> > 
> > I thinks stubdom/c/minios.cfg should be like this.
> 
> That sounds plausible. I'm not sure what would then include the tests at
> that point though.

IIRC, by building mini-os by itself (without any stubdom part, i.e. no
libc)

> If Samuel agrees with the patch

Yes.  I wonder how that didn't pose problem so far.

> please could you formally submit according to
> http://wiki.xen.org/wiki/Submitting_Xen_Patches

Samuel

Re: [BUG]Cannot build mini-os-x86_64-c

[Ian Campbell]

On Fri, 2014-02-07 at 01:34 +0100, Samuel Thibault wrote:
> Ian Campbell, le Mon 03 Feb 2014 10:28:07 +0000, a écrit :
> > On Sat, 2014-02-01 at 17:55 +0900, Masaki Muranaka wrote:
> > > I got the build error. Log is like this:
> > > /home/azureuser/xen/stubdom/mini-os-x86_64-c/test.o: In function
> > > `app_main':
> > > 
> > > /home/azureuser/xen/extras/mini-os/test.c:542: multiple definition of
> > > `app_main'
> > > /home/azureuser/xen/stubdom/mini-os-x86_64-c/main.o:/home/azureuser/xen/extras/mini-os/main.c:187: first defined here
> > > make[1]: *** [/home/azureuser/xen/stubdom/mini-os-x86_64-c/mini-os]
> > > Error 1
> > > make[1]: Leaving directory `/home/azureuser/xen/extras/mini-os'
> > > make: *** [c-stubdom] Error 2
> > > 
> > > 
> > > 
> > > 
> > > I thinks stubdom/c/minios.cfg should be like this.
> > 
> > That sounds plausible. I'm not sure what would then include the tests at
> > that point though.
> 
> IIRC, by building mini-os by itself (without any stubdom part, i.e. no
> libc)

I thought that but I wasn't able to confirm by inspection of the
Makefile etc. It's not a big deal IMHO, if someone cares they will fix
it...

> > If Samuel agrees with the patch
> 
> Yes.  I wonder how that didn't pose problem so far.

I don't think we build the c stubdom by default -- maybe for this
reason.

Masaki, if you submit a patch you could also consider adding this to the
default set of stubdoms to build (or not, up to you).

Ian.

> 
> > please could you formally submit according to
> > http://wiki.xen.org/wiki/Submitting_Xen_Patches
> 
> Samuel



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [BUG]Cannot build mini-os-x86_64-c

[Samuel Thibault]

Ian Campbell, le Fri 07 Feb 2014 10:02:03 +0000, a écrit :
> > > I'm not sure what would then include the tests at
> > > that point though.
> > 
> > IIRC, by building mini-os by itself (without any stubdom part, i.e. no
> > libc)
> 
> I thought that but I wasn't able to confirm by inspection of the
> Makefile etc. It's not a big deal IMHO, if someone cares they will fix
> it...

One has to run "make CONFIG_TEST=y" to get it.

> > > If Samuel agrees with the patch
> > 
> > Yes.  I wonder how that didn't pose problem so far.
> 
> I don't think we build the c stubdom by default -- maybe for this
> reason.

Ok.

Samuel