From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, xen-devel@lists.xen.org
Subject: Re: missing dependency on libxlu_disk_l.h
Date: Tue, 18 Feb 2014 14:56:41 +0100 [thread overview]
Message-ID: <20140218135641.GB2804@aepfle.de> (raw)
In-Reply-To: <21251.17769.656791.139815@mariner.uk.xensource.com>
On Tue, Feb 18, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] missing dependency on libxlu_disk_l.h"):
> > It might be a good idea to either also patch the generated files or to
> > have the patch remove them, to avoid any possible confusion due to skew.
> This ought to be taken care of by the build system, provided you don't
> actually git commit only the change to .l and not the change to .[ch].
> In the final patch.
In my case the patch changes only the .l file. I expect that all
dependencies are written into the Makefile.
> Olaf, can you test whether this diff makes the problem go away for you ?
Ian, xen.rpm is rebuilt often, but the failure happend exactly once.
I will see if I can force it to fail without the change below.
Olaf
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index dab2929..755b666 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -98,7 +98,7 @@ TEST_PROGS += $(foreach t, $(LIBXL_TESTS),test_$t)
> $(LIBXL_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
>
> AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h \
> - _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
> + libxlu_disk_l.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
> AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
> AUTOSRCS += _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
> LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \
next prev parent reply other threads:[~2014-02-18 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 22:17 missing dependency on libxlu_disk_l.h Olaf Hering
2014-02-18 10:18 ` Ian Campbell
2014-02-18 11:35 ` Ian Jackson
2014-02-18 13:56 ` Olaf Hering [this message]
2014-02-18 14:21 ` Olaf Hering
2014-02-18 14:53 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218135641.GB2804@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).