From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, konrad@kernel.org
Subject: Re: [RFC PATCHv1] serial: Support OXPCIe952 aka Oxford Semiconductor Ltd Device c138 (1415:c138)
Date: Tue, 04 Mar 2014 05:36:21 -0500 [thread overview]
Message-ID: <201403041036.s24AaOu9019510@userz7021.oracle.com> (raw)
On Mar 4, 2014 4:43 AM, Jan Beulich <JBeulich@suse.com> wrote:
>
> >>> On 04.03.14 at 03:01, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote:
> > @@ -325,11 +342,12 @@ static void __init ns16550_init_preirq(struct serial_port *port)
> > #ifdef CONFIG_X86
> > enum fixed_addresses idx = FIX_COM_BEGIN + (uart - ns16550_com);
> >
> > - set_fixmap_nocache(idx, uart->io_base);
> > + set_fixmap_nocache(idx, uart->io_base + uart->offset);
> > uart->remapped_io_base = (void __iomem *)fix_to_virt(idx);
> > uart->remapped_io_base += uart->io_base & ~PAGE_MASK;
>
> Don't you need to add in uart->offset here too?
The virtual address at that point already covers then BAR + offset.
>
> > #else
> > - uart->remapped_io_base = (char *)ioremap(uart->io_base, uart->io_size);
> > + uart->remapped_io_base = (char *)ioremap(uart->io_base+ uart->offset,
>
> Missing space.
Fixed.
>
> > + uart->io_size);
> > #endif
> > }
> >
>
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next reply other threads:[~2014-03-04 10:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 10:36 Konrad Rzeszutek Wilk [this message]
2014-03-04 10:57 ` [RFC PATCHv1] serial: Support OXPCIe952 aka Oxford Semiconductor Ltd Device c138 (1415:c138) Jan Beulich
2014-03-04 13:29 ` Konrad Rzeszutek Wilk
2014-03-04 15:39 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2014-03-04 2:01 Konrad Rzeszutek Wilk
2014-03-04 3:17 ` Julien Grall
2014-03-04 9:43 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201403041036.s24AaOu9019510@userz7021.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=konrad@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).