* libxl error reporting
@ 2014-03-06 8:11 Olaf Hering
2014-03-06 12:11 ` Ian Jackson
0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2014-03-06 8:11 UTC (permalink / raw)
To: Ian.Jackson, ian.campbell; +Cc: xen-devel
How are users of libxl supposed to report errors that occour during an
libxl function call?
For example "virsh migrate" calls libxl_domain_suspend, which has many
ways to fail. What details about the specific error should be returned
to the caller? Right now its just some sort of libxl_error. All virsh
could do is to show "please see logfile for details".
I think this specifc function should return some sort of state, which is
preserved within the function call. It could be something like "remote
side had issues", "guest was too busy", "guest lacks PV drivers", "some
unexpected (internal) error".
Unfortunately libxl.h contains nothing about error handling.
Olaf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: libxl error reporting
2014-03-06 8:11 libxl error reporting Olaf Hering
@ 2014-03-06 12:11 ` Ian Jackson
2014-03-11 9:58 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2014-03-06 12:11 UTC (permalink / raw)
To: Olaf Hering; +Cc: ian.campbell, xen-devel
Olaf Hering writes ("libxl error reporting"):
> For example "virsh migrate" calls libxl_domain_suspend, which has many
> ways to fail. What details about the specific error should be returned
> to the caller? Right now its just some sort of libxl_error. All virsh
> could do is to show "please see logfile for details".
Unfortunately, yes.
> I think this specifc function should return some sort of state, which is
> preserved within the function call. It could be something like "remote
> side had issues", "guest was too busy", "guest lacks PV drivers", "some
> unexpected (internal) error".
>
> Unfortunately libxl.h contains nothing about error handling.
I have been considering a campaign of adding (many) more error codes.
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: libxl error reporting
2014-03-06 12:11 ` Ian Jackson
@ 2014-03-11 9:58 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2014-03-11 9:58 UTC (permalink / raw)
To: Ian Jackson; +Cc: Olaf Hering, xen-devel
On Thu, 2014-03-06 at 12:11 +0000, Ian Jackson wrote:
> Olaf Hering writes ("libxl error reporting"):
> > For example "virsh migrate" calls libxl_domain_suspend, which has many
> > ways to fail. What details about the specific error should be returned
> > to the caller? Right now its just some sort of libxl_error. All virsh
> > could do is to show "please see logfile for details".
>
> Unfortunately, yes.
libvirt could also provide its own xtllog implementation which could
store and provide the log messages in a "virsh friendly" manner
(whatever that might be) as well as logging (if it wants).
> > I think this specifc function should return some sort of state, which is
> > preserved within the function call. It could be something like "remote
> > side had issues", "guest was too busy", "guest lacks PV drivers", "some
> > unexpected (internal) error".
> >
> > Unfortunately libxl.h contains nothing about error handling.
>
> I have been considering a campaign of adding (many) more error codes.
Good idea.
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-11 9:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-06 8:11 libxl error reporting Olaf Hering
2014-03-06 12:11 ` Ian Jackson
2014-03-11 9:58 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).