From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v2 4/7] serial: Seperate the PCI device ids
	and parameters
Date: Mon, 10 Mar 2014 12:38:54 -0400
Message-ID: <20140310163854.GK4262@phenom.dumpdata.com>
References: <1394218904-21535-1-git-send-email-konrad.wilk@oracle.com>
	<1394218904-21535-5-git-send-email-konrad.wilk@oracle.com>
	<531D96E4020000780012242C@nat28.tlf.novell.com>
	<20140310162316.GF4262@phenom.dumpdata.com>
	<531DF6C402000078001227B2@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <konrad.wilk@oracle.com>) id 1WN3EH-00035y-Cw
	for xen-devel@lists.xenproject.org; Mon, 10 Mar 2014 16:39:05 +0000
Content-Disposition: inline
In-Reply-To: <531DF6C402000078001227B2@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: andrew.cooper3@citrix.com, aravind.gopalakrishnan@amd.com, xen-devel@lists.xenproject.org, Konrad Rzeszutek Wilk <konrad@kernel.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, Mar 10, 2014 at 04:30:44PM +0000, Jan Beulich wrote:
> >>> On 10.03.14 at 17:23, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> > On Mon, Mar 10, 2014 at 09:41:40AM +0000, Jan Beulich wrote:
> >> >>> On 07.03.14 at 20:01, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote:
> >> > @@ -96,28 +100,27 @@ struct ns16550_config_mmio {
> >> >  
> >> >  
> >> >  #ifdef HAS_PCI
> >> > +enum ns16550_config_param_nr {
> >> 
> >> Perhaps better e.g. _kind or _idx rather than _nr? But in the end
> >> you don't use the enum tag anyway, so you could as well leave out
> >> the tag altogether.
> > 
> > OK, will replace it with #defines.
> 
> But that wasn't what I meant.

My apologies.

My brain parsed this statement: 'don't use the enum tag.. leave out the tag altogether'
as the 'enum' not being useful. But you meant the '_nr'.
> 
> > How does that look to you?
> 
> Quite okay. I think that using an enum here is quite appropriate/
> desirable here, but I also don't heavily object the #define approach.

Heh. Let me revert it back to the enum as it will give future developers
a clear path of how to expand the list of parameters for other serial
devices.

> 
> Jan
>