From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian.Campbell@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 4/4 v2] tools/xc: pass errno to callers of xc_domain_save
Date: Mon, 10 Mar 2014 19:24:36 +0100 [thread overview]
Message-ID: <20140310182436.GA24517@aepfle.de> (raw)
In-Reply-To: <21277.61301.269725.74179@mariner.uk.xensource.com>
On Mon, Mar 10, Ian Jackson wrote:
> Can I suggest that these cases could probably benefit from
> assert(errno)
I think that verifying errno in that case is a good thing. But:
Wouldnt that abort() applications using libxc, including libvirtd?
Olaf
next prev parent reply other threads:[~2014-03-10 18:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 9:15 [PATCH 0/4] tools/libxc: various errno changes Olaf Hering
2014-03-07 9:15 ` [PATCH 1/4] tools/libxc: remove double inclusion of errno.h Olaf Hering
2014-03-10 16:50 ` Ian Jackson
2014-03-07 9:15 ` [PATCH 2/4] tools/libxc: assign positive values to errno Olaf Hering
2014-03-10 16:51 ` Ian Jackson
2014-03-11 13:17 ` Ian Campbell
2014-03-11 14:35 ` Olaf Hering
2014-03-11 14:39 ` Ian Campbell
2014-03-11 15:24 ` Ian Jackson
2014-03-07 9:15 ` [PATCH 3/4] tools/xc: preserve errno in ERROR and DRINTF macros Olaf Hering
2014-03-10 16:51 ` Ian Jackson
2014-03-07 9:15 ` [PATCH 4/4 v2] tools/xc: pass errno to callers of xc_domain_save Olaf Hering
2014-03-10 16:59 ` Ian Jackson
2014-03-10 18:24 ` Olaf Hering [this message]
2014-03-11 7:49 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310182436.GA24517@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).