From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: usage of libxl__sprintf for flexarray_append
Date: Mon, 17 Mar 2014 10:27:58 +0100 [thread overview]
Message-ID: <20140317092758.GA12890@aepfle.de> (raw)
In-Reply-To: <1395048261.4122.4.camel@kazak.uk.xensource.com>
On Mon, Mar 17, Ian Campbell wrote:
> I think it's just a historic accident. Feel free to fix.
Ok, thanks.
> If you are touching this stuff then IMHO the chains of flexarray_appends
> for key/value pairs should use flexarray_append_pair to make it clearer
> they are related, but perhaps that's a cleanup for another time.
I'm using this already for new code, and I plan to adjust other places
in that file to make use of flexarray_append_pair.
Olaf
prev parent reply other threads:[~2014-03-17 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 9:15 usage of libxl__sprintf for flexarray_append Olaf Hering
2014-03-17 9:24 ` Ian Campbell
2014-03-17 9:27 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317092758.GA12890@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).