From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: usage of libxl__sprintf for flexarray_append
Date: Mon, 17 Mar 2014 10:27:58 +0100
Message-ID: <20140317092758.GA12890@aepfle.de>
References: <20140317091555.GA10100@aepfle.de>
	<1395048261.4122.4.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1395048261.4122.4.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, Mar 17, Ian Campbell wrote:

> I think it's just a historic accident. Feel free to fix.

Ok, thanks.

> If you are touching this stuff then IMHO the chains of flexarray_appends
> for key/value pairs should use flexarray_append_pair to make it clearer
> they are related, but perhaps that's a cleanup for another time.

I'm using this already for new code, and I plan to adjust other places
in that file to make use of flexarray_append_pair.

Olaf