From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: ian.campbell@citrix.com, Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <iwj@mariner.uk.xensource.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH RFC V3 5/7] Introduce ts-debian-hvm-install
Date: Thu, 20 Mar 2014 17:01:12 +0000 [thread overview]
Message-ID: <20140320170112.GT16807@zion.uk.xensource.com> (raw)
In-Reply-To: <21291.5098.888643.516290@mariner.uk.xensource.com>
On Thu, Mar 20, 2014 at 04:14:34PM +0000, Ian Jackson wrote:
> Ian Jackson writes ("Re: [PATCH RFC V3 5/7] Introduce ts-debian-hvm-install"):
> > Wei Liu writes ("[PATCH RFC V3 5/7] Introduce ts-debian-hvm-install"):
> > > This is debian hvm guest test case. It resembles ts-redhat-install:
> > > 1. prepare a auto install CD
> > > 2. install debian hvm guest, currently using OVMF
> > > 3. test if the guest is up
> > ...
> > > ts-debian-hvm-install | 202 +++++++++++++++++++++++++++++++++++++++++++++++++
>
> Uh, I am a total snooze today.
>
> > This script has, I'm afraid, far too much clone-and-hack from
> > ts-redhat-install.
>
> This is true.
>
What will you suggest? One thing I can think of is to move
rewrite_config_nocd to TestSupport.pm. The major body looks
Debian-centric to me.
The process is similar to ts-redhat-install -- they both have prep(),
rewrite etc. But inside the prep() function there are actually many
differences.
Wei.
next prev parent reply other threads:[~2014-03-20 17:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 21:02 [PATCH RFC V3 0/7] OSSTest: OVMF test job Wei Liu
2013-12-12 21:02 ` [PATCH RFC V3 1/7] make-flight: disable OVMF build for 4.3 Wei Liu
2013-12-12 21:06 ` Wei Liu
2013-12-12 21:02 ` [PATCH RFC V3 2/7] TestSupport.pm: add bios option to guest config file Wei Liu
2013-12-12 21:03 ` [PATCH RFC V3 3/7] TestSupport.pm: functions for creating isos Wei Liu
2014-03-20 16:10 ` Ian Jackson
2014-03-20 16:56 ` Wei Liu
2014-03-20 17:04 ` Ian Jackson
2013-12-12 21:03 ` [PATCH RFC V3 4/7] Debian.pm: factor out preseed_base Wei Liu
2014-03-20 16:10 ` Ian Jackson
2013-12-12 21:03 ` [PATCH RFC V3 5/7] Introduce ts-debian-hvm-install Wei Liu
2014-03-20 16:13 ` Ian Jackson
2014-03-20 16:14 ` Ian Jackson
2014-03-20 17:01 ` Wei Liu [this message]
2014-03-20 17:11 ` Ian Jackson
2013-12-12 21:03 ` [PATCH RFC V3 6/7] make-flight: OVMF test filght Wei Liu
2013-12-12 21:03 ` [PATCH RFC V3 7/7] sg-run-job: OVMF job Wei Liu
2014-03-20 16:16 ` Ian Jackson
2014-01-22 15:52 ` [PATCH RFC V3 0/7] OSSTest: OVMF test job Wei Liu
2014-03-20 16:03 ` Ian Campbell
2014-03-20 16:17 ` Ian Jackson
2014-03-20 17:02 ` Wei Liu
2014-03-20 17:14 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320170112.GT16807@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=iwj@mariner.uk.xensource.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).