From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH RFC V3 5/7] Introduce ts-debian-hvm-install Date: Thu, 20 Mar 2014 17:01:12 +0000 Message-ID: <20140320170112.GT16807@zion.uk.xensource.com> References: <1386882184-15324-1-git-send-email-wei.liu2@citrix.com> <1386882184-15324-6-git-send-email-wei.liu2@citrix.com> <21291.5016.278769.30846@mariner.uk.xensource.com> <21291.5098.888643.516290@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <21291.5098.888643.516290@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: ian.campbell@citrix.com, Wei Liu , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, Mar 20, 2014 at 04:14:34PM +0000, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH RFC V3 5/7] Introduce ts-debian-hvm-install"): > > Wei Liu writes ("[PATCH RFC V3 5/7] Introduce ts-debian-hvm-install"): > > > This is debian hvm guest test case. It resembles ts-redhat-install: > > > 1. prepare a auto install CD > > > 2. install debian hvm guest, currently using OVMF > > > 3. test if the guest is up > > ... > > > ts-debian-hvm-install | 202 +++++++++++++++++++++++++++++++++++++++++++++++++ > > Uh, I am a total snooze today. > > > This script has, I'm afraid, far too much clone-and-hack from > > ts-redhat-install. > > This is true. > What will you suggest? One thing I can think of is to move rewrite_config_nocd to TestSupport.pm. The major body looks Debian-centric to me. The process is similar to ts-redhat-install -- they both have prep(), rewrite etc. But inside the prep() function there are actually many differences. Wei.