From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [PATCH v2 1/7] xenstore-read: add support for a retry open limit on xenstored Date: Sat, 22 Mar 2014 02:41:15 +0100 Message-ID: <20140322014115.GD5011@wotan.suse.de> References: <1395262733-11885-1-git-send-email-mcgrof@do-not-panic.com> <1395262733-11885-2-git-send-email-mcgrof@do-not-panic.com> <532C5D55.5070509@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3360192608092699519==" Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WRAw4-0001jd-5m for xen-devel@lists.xenproject.org; Sat, 22 Mar 2014 01:41:20 +0000 In-Reply-To: <532C5D55.5070509@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: Ian Campbell , Stefano Stabellini , Jan =?utf-8?Q?R=C4=99korajski?= , Ian Jackson , Jacek Konieczny , M A Young , xen-devel@lists.xenproject.org, "Luis R. Rodriguez" List-Id: xen-devel@lists.xenproject.org --===============3360192608092699519== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kfjH4zxOES6UT95V" Content-Disposition: inline --kfjH4zxOES6UT95V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 21, 2014 at 03:40:05PM +0000, David Vrabel wrote: > On 19/03/14 20:58, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > >=20 > > This adds support for a customizable retry limit on trying to open > > the xenstored, each retry is separated by 1 second. This should allow > > us to simplify both our LSB init scripts and eventually our systemd > > service files for starting the xenstored. >=20 >=20 > This seems odd. Surely the point of systemd is that you only start > services once their dependencies are up? It doesn't seem right to have > a service poll for another. I was unable to verify the dogs will be let loose only once a service which claims a socket is available, so I left the check for now but I think once we do confirm this we should remove it. This retry is also useful for the old LSB scripts though too, it just shaves off of the existing shell script. > > diff --git a/tools/xenstore/xenstore_client.c b/tools/xenstore/xenstore= _client.c > > index 0ec103f..87972b7 100644 > > --- a/tools/xenstore/xenstore_client.c > > +++ b/tools/xenstore/xenstore_client.c > > @@ -77,7 +77,8 @@ usage(enum mode mode, int incl_mode, const char *prog= name) > > errx(1, "Usage: %s [-h] [...]", progname); > > case MODE_read: > > mstr =3D incl_mode ? "read " : ""; > > - errx(1, "Usage: %s %s[-h] [-p] [-s] key [...]", progname, mstr); > > + errx(1, "Usage: %s %s[-h] [-p] [-s] [ -l ] key [...]= ", > > + progname, mstr); >=20 > The command line option would be better as a time out value (in seconds). -t for "tidy" is taken, let me know what you guys decide for preference. Luis --kfjH4zxOES6UT95V Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAEBAgAGBQJTLOo7AAoJEPep4JnvMe6zPdUQAJMe/IItF15mvDQsz4ZL63K4 sTUP4M65z0b+QEUiGWfXe3vIsV7/Su0PfR4JpKIY19pDMoFUA3GwDVS0ZWGXtP1E 832OM06NcF1rqboNDJewx0MK/7um036zgOFFuiGTC1P3kxB8e+3wLsoKvfeD3826 q8XQ/ia06CX72CD8nZ3rwTtXysQLvMD26J56yv9FB/6bBTvr7GcDNxXUc6S+JTNt s3pNKU+AmB07inYpveiEjB+8UnQjNPIFZaNbNFyRzDaD2rn7oErmyMYzqvtYHzQo eubV3obRBYs9ek84apYkF4ZbPyAd7v0kKQw0mXjSrhGHuK2b6btccIeCucLQnB4A WtU2OkSAHZgLIWEaKaC/Zk2leGzU4ZWsxglYZ8fAHnPP4KEn00IccwXbhXkFBVj2 8QC6HUAkHafr5FGDMILrG8PcnmUgeCnSdjC/Id5S/Y2ABDzQwDUp/Szlt8gJhhLB jZJKKBKUt3sXthQZwtz+kPgKp638XrCkxIkM0hS7jeC+n8kPsEMo29weC3Sf9knT sikxLu/l3vQP3UvOBMOj6GUdFmTuSTp1ah0en5d+P5wx9Ve67lUyIjXbNM/c50iC i6eCOTEZlCEbU/Xvkb6FfZ8q8QZO0xUUMFqQenaqbMCPLynjKEP0F57TbKwoGIBW decp89LCo/PvVdAaawBL =CPIH -----END PGP SIGNATURE----- --kfjH4zxOES6UT95V-- --===============3360192608092699519== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3360192608092699519==--