From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [PATCH v2 1/7] xenstore-read: add support for a retry open limit on xenstored Date: Sat, 22 Mar 2014 02:43:59 +0100 Message-ID: <20140322014359.GE5011@wotan.suse.de> References: <1395262733-11885-1-git-send-email-mcgrof@do-not-panic.com> <1395262733-11885-2-git-send-email-mcgrof@do-not-panic.com> <532C5D55.5070509@citrix.com> <1395417690.19839.163.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4600484418079425404==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WRAyf-00031A-AH for xen-devel@lists.xenproject.org; Sat, 22 Mar 2014 01:44:01 +0000 In-Reply-To: <1395417690.19839.163.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Stefano Stabellini , Jan =?utf-8?Q?R=C4=99korajski?= , Ian Jackson , Jacek Konieczny , David Vrabel , M A Young , xen-devel@lists.xenproject.org, "Luis R. Rodriguez" List-Id: xen-devel@lists.xenproject.org --===============4600484418079425404== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jCrbxBqMcLqd4mOl" Content-Disposition: inline --jCrbxBqMcLqd4mOl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 21, 2014 at 04:01:30PM +0000, Ian Campbell wrote: > On Fri, 2014-03-21 at 15:40 +0000, David Vrabel wrote: > > On 19/03/14 20:58, Luis R. Rodriguez wrote: > > > From: "Luis R. Rodriguez" > > >=20 > > > This adds support for a customizable retry limit on trying to open > > > the xenstored, each retry is separated by 1 second. This should allow > > > us to simplify both our LSB init scripts and eventually our systemd > > > service files for starting the xenstored. > >=20 > >=20 > > This seems odd. Surely the point of systemd is that you only start > > services once their dependencies are up? It doesn't seem right to have > > a service poll for another. >=20 > Isn't this trying to decide when xenstored is up, for use in the > xenstored.service itself? >=20 > But now I think of it -- isn't this exactly what the socket activation > stuff is for? Strangely enough the socket file gets systemd to kick off the socket=20 prior to xenstored activation, I was baffled by this and since the documentation is shy about the details I could not trust what I assumed and everyone else is assuming systemd *should* be doing. We'll have to dive into the code and verify before knowing for sure we won't let through an attempt to access xenstored without the old legacy retry. Luis --jCrbxBqMcLqd4mOl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAEBAgAGBQJTLOreAAoJEPep4JnvMe6zjUAP/RCpRLAkg2C8obmJKeNeUskV YNjbA1qQcPVZwVho6TuR0ja1Nutd9N4Sn6kAKikfj/WMTkBkuCGkGL4UwIm8c4+h m+pQiQUuh8c97DDgb4SDihAY7w6V/5ktSF30lJ1gwFPDphf4E4sWMrvjzme3Krj2 mmJWoMgnUPuf2RLN5UVqZoRWiNfD7RW+JHjoDxm028c95PsMjWn99tnmQVdy5HBa 4Oj7u9P4jwkp+327QDZC7GLhLL+D+KELCojemYVs6/XBz2A2D+KdOEvnr51nOdpJ Jh9OHc2rtjUbDjYj4kcS3Wrol8i5rr6o+dYxWvMX/cClDU0nmCvY398ygAqjLosw f5VlKps+F+6Qa9CqC/RffAuo2RLdvctu0VDJ5QCb6nl1JHbn2uqw/2dKXboPWAJi moZVsHNeWINo10ODkI0aIfIpqFsMy7j+dVnG3vUcn0tkfNNYe9Y2fSgiHOktUkoo RbDvt6/S1R6EJt9E9A4W25cD+Mi0KZhhQV/banPB2pM3eGqeD3hf8H6X7rrf5MxU jb0IDKqyJ1saqBa7+f0eC2ejKWVqaBk9mJ3abGa2bth8V5C37fRKRfRHzln6ANG5 s2Fa16WHYXDCLE3X94O/OajU6/126lEx3P50ToKvMfqppfFE5uwMHvBMXwiwixv6 pMGxph8i70U4Al7AL3Gx =Mf10 -----END PGP SIGNATURE----- --jCrbxBqMcLqd4mOl-- --===============4600484418079425404== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4600484418079425404==--