Re: Avoid said the /dev/xvd* is already defined after open a vhd file failed

[Matt Wilson <msw@linux.com>]

On Mon, Mar 24, 2014 at 11:52:56AM +0000, George Dunlap wrote:
> On Wed, Mar 19, 2014 at 3:12 PM, 李义 <yilikernel@gmail.com> wrote:
> > Hi Guys,
> >
> > can you do me a favor to check it. Thanks.
> 
> CC'ing the xend maintainer...

Thanks, George.

>  -George
> 
> >
> > From 9f45c734af00a1af71f7cd69f0473474bcd739da Mon Sep 17 00:00:00 2001
> > From: Yi Li <peteryili@tencent.com>
> > Date: Wed, 19 Mar 2014 22:54:16 +0800
> > Subject: [PATCH] Avoid said the /dev/xvd* is already defined after
> > open a vhd file failed
> >
> > For example:
> > [root@dom0_134_103 ~]# xm block-attach 0
> > tap2:tapdisk:vhd:/root/liyi***.vhd /dev/xvdz  w
> > Error: ('create', '-avhd:/root/liyi***.vhd') failed (512  )
> > Usage: xm block-attach <Domain> <BackDev> <FrontDev> <Mode> [BackDomain]
> > Create a new virtual block device.
> >
> > [root@dom0_134_103 ~]# xm block-attach 0
> > tap2:tapdisk:vhd:/root/liyi.vhd /dev/xvdz  w
> > Error: The device "/dev/xvdz" is already defined
> > Usage: xm block-attach <Domain> <BackDev> <FrontDev> <Mode> [BackDomain]
> >
> > Create a new virtual block device.
> >
> > Signed-off-by: Yi Li <peteryili@tencent.com>

Acked-by: Matt Wilson <msw@amazon.com>

> > ---
> >  tools/python/xen/xend/XendDomainInfo.py |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/python/xen/xend/XendDomainInfo.py
> > b/tools/python/xen/xend/XendDomainInfo.py
> > index 8d4ff5c..2270ab1 100644
> > --- a/tools/python/xen/xend/XendDomainInfo.py
> > +++ b/tools/python/xen/xend/XendDomainInfo.py
> > @@ -65,7 +65,7 @@ from xen.xend.XendConstants import *
> >  from xen.xend.XendAPIConstants import *
> >  from xen.xend.XendCPUPool import XendCPUPool
> >  from xen.xend.server.DevConstants import xenbusState
> > -from xen.xend.server.BlktapController import TapdiskController
> > +from xen.xend.server.BlktapController import TapdiskController,
> > TapdiskException
> >
> >  from xen.xend.XendVMMetrics import XendVMMetrics
> >
> > @@ -861,7 +861,7 @@ class XendDomainInfo:
> >                      # blktap1
> >                      dev_type = self.getBlockDeviceClass(devid)
> >                  self._waitForDevice(dev_type, devid)
> > -            except VmError, ex:
> > +            except (VmError, TapdiskException), ex:
> >                  del self.info['devices'][dev_uuid]
> >                  if dev_type == 'pci':
> >                      for dev in dev_config_dict['devs']:

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel