From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [V8 PATCH 3/8] pvh dom0: Introduce p2m_map_foreign
Date: Fri, 4 Apr 2014 17:57:26 -0700
Message-ID: <20140404175726.100ea1e3@mantra.us.oracle.com>
References: <1395452357-1598-1-git-send-email-mukesh.rathor@oracle.com>
	<1395452357-1598-4-git-send-email-mukesh.rathor@oracle.com>
	<5334198F.9050907@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <mukesh.rathor@oracle.com>) id 1WWEvT-0002c7-H4
	for xen-devel@lists.xenproject.org; Sat, 05 Apr 2014 00:57:39 +0000
In-Reply-To: <5334198F.9050907@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, keir.xen@gmail.com, tim@xen.org, JBeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

On Thu, 27 Mar 2014 12:29:03 +0000
George Dunlap <george.dunlap@eu.citrix.com> wrote:

> On 03/22/2014 01:39 AM, Mukesh Rathor wrote:
> > @@ -751,16 +750,31 @@ set_mmio_p2m_entry(struct domain *d, unsigned
> > long gfn, mfn_t mfn) set_gpfn_from_mfn(mfn_x(omfn),
> > INVALID_M2P_ENTRY); }
.......
> > -    P2M_DEBUG("set mmio %lx %lx\n", gfn, mfn_x(mfn));
> > -    rc = set_p2m_entry(p2m, gfn, mfn, PAGE_ORDER_4K,
> > p2m_mmio_direct, p2m->default_access);
> > +    P2M_DEBUG("set %d %lx %lx\n", gfn_p2mt, gfn, mfn_x(mfn));
> > +    rc = set_p2m_entry(p2m, gfn, mfn, PAGE_ORDER_4K, gfn_p2mt,
> > +                       p2m->default_access);
> >       gfn_unlock(p2m, gfn, 0);
> >       if ( 0 == rc )
> >           gdprintk(XENLOG_ERR,
> > -            "set_mmio_p2m_entry: set_p2m_entry failed!
> > mfn=%08lx\n",
> > +            "%s: set_p2m_entry failed! mfn=%08lx\n", __func__,
> >               mfn_x(get_gfn_query_unlocked(p2m->domain, gfn, &ot)));
> >       return rc;
> >   }
> >   
> > +/* Set foreign mfn in the given guest's p2m table.
> > + * Returns: True for success. */
> > +static int __attribute__((unused))
> > +set_foreign_p2m_entry(struct domain *d, unsigned long gfn, mfn_t
> > mfn)
> 
> Why "unused"?  It appears that tag remains even at the end of the
> series.

Ooops, meant to undo "unused" in patch 5 where its being called. I
am surprised the compiler didn't complain on that.... 

anyways, will fix it to undo in patch 5 so patch 3 can compile.

thanks
mukesh