From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Rathor Subject: Re: [V9 PATCH 7/8] pvh dom0: check for vioapic null ptr in vioapic_range Date: Wed, 16 Apr 2014 18:44:48 -0700 Message-ID: <20140416184448.25c62fb1@mantra.us.oracle.com> References: <1397607172-32065-1-git-send-email-mukesh.rathor@oracle.com> <1397607172-32065-8-git-send-email-mukesh.rathor@oracle.com> <534EC6850200007800009B08@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WabNs-00085f-5C for xen-devel@lists.xenproject.org; Thu, 17 Apr 2014 01:45:00 +0000 In-Reply-To: <534EC6850200007800009B08@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: George.Dunlap@eu.citrix.com, tim@xen.org, eddie.dong@intel.com, keir.xen@gmail.com, jun.nakajima@intel.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Wed, 16 Apr 2014 17:05:57 +0100 "Jan Beulich" wrote: > >>> On 16.04.14 at 02:12, wrote: > > pvh doesn't use apic emulation, as a result vioapic_init is not > > called and vioapic ptr in struct hvm_domain is not initialized. One > > path that would access the ptr for pvh is : > > > > hvm_hap_nested_page_fault -> handle_mmio -> hvmemul_do_io -> > > hvm_mmio_intercept -> vioapic_range > > Given this I'm not sure the guard belongs here. The majority of the > handle_mmio() logic should never be used for Dom0. Perhaps you > should simply have a pvh_mmio_handlers[] paralleling > hvm_mmio_handlers[], but (presumably) only having HPET and MSI-X > entries for now? Well, there's already talk of adding vioapic support for PVH so it could take advantage of the new features coming up. So, it'll prob converge in near future with hvm_mmio_handlers . I'm ok either way. thanks, Mukesh