xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Ian.Campbell@citrix.com, Ian.Jackson@eu.citrix.com
Cc: xen-devel@lists.xen.org
Subject: usage of fixed path in hotplug scripts
Date: Thu, 17 Apr 2014 16:06:14 +0200	[thread overview]
Message-ID: <20140417140614.GA27737@aepfle.de> (raw)


Ian,

is there a reason /etc/init.d/xencommons uses a hardcoded path to
/etc/xen/scripts/hotplugpath.sh, while that file actually contains all
the variable paths? Should make install do some sort of 

        sed "s^@XEN_SCRIPT_DIR@$XEN_SCRIPT_DIR@" \
        tools/hotplug/Linux/init.d/xencommons \
        > $DESTDIR$(XENCOMMONS_INITD)/xencommons

(or whatever the correct syntax would be)

My point is that some parts of the paths can be configured, but these
paths are not used. Instead hardcoded paths are used.


Olaf

             reply	other threads:[~2014-04-17 14:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-17 14:06 Olaf Hering [this message]
2014-04-22  8:33 ` usage of fixed path in hotplug scripts Ian Campbell
2014-04-22 11:37   ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140417140614.GA27737@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).