From: Olaf Hering <olaf@aepfle.de>
To: Jan Beulich <JBeulich@suse.com>
Cc: keir@xen.org, tim@xen.org, ian.jackson@eu.citrix.com,
ian.campbell@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen: use XEN_BOOT_DIR as xen.gz install location
Date: Wed, 23 Apr 2014 11:39:22 +0200 [thread overview]
Message-ID: <20140423093922.GA1191@aepfle.de> (raw)
In-Reply-To: <5357A558020000780000B40E@nat28.tlf.novell.com>
On Wed, Apr 23, Jan Beulich wrote:
> >>> On 23.04.14 at 10:00, <olaf@aepfle.de> wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -13,6 +13,7 @@ export BASEDIR := $(CURDIR)
> > export XEN_ROOT := $(BASEDIR)/..
> >
> > EFI_MOUNTPOINT ?= /boot/efi
> > +XEN_BOOT_DIR ?= /boot
>
> Did it not occur to you that the immediately preceding line then
> would also need changing? I'm also not certain about the need for
> the XEN_ prefix on the new variable - there's nothing Xen-specific
> about the location of the boot directory/partition.
Why would EFI_MOUNTPOINT need a change? If it does not fit it can be
changed at build time. But I'm fine with something like
BOOT_DIR ?= /boot
EFI_MOUNTPOINT ?= $(BOOT_DIR)/efi
Olaf
next prev parent reply other threads:[~2014-04-23 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 8:00 [PATCH] xen: use XEN_BOOT_DIR as xen.gz install location Olaf Hering
2014-04-23 8:09 ` Roger Pau Monné
2014-04-23 8:24 ` Olaf Hering
2014-04-23 9:37 ` Jan Beulich
2014-04-23 9:40 ` Olaf Hering
2014-04-23 11:33 ` Ian Campbell
2014-04-23 14:46 ` Roger Pau Monné
2014-04-23 9:34 ` Jan Beulich
2014-04-23 9:39 ` Olaf Hering [this message]
2014-04-23 9:47 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423093922.GA1191@aepfle.de \
--to=olaf@aepfle.de \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).