From: Wei Liu <wei.liu2@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>,
ian.jackson@eu.citrix.com, Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH RFC V2 05/10] libxl_json: introduce parser functions for builtin types
Date: Wed, 23 Apr 2014 13:00:29 +0100 [thread overview]
Message-ID: <20140423120029.GD7712@zion.uk.xensource.com> (raw)
In-Reply-To: <1398253306.18537.59.camel@kazak.uk.xensource.com>
On Wed, Apr 23, 2014 at 12:41:46PM +0100, Ian Campbell wrote:
[...]
> > >
> > > The way I see it is that in current libxl code, the caller , regardless
> >
> > Sorry I meant "xl code".
>
> It does look that way doesn't it. Lets go for consistency for sure!
>
> Any chance you could add a comment to a relevant section of libxl.h to
> describe this expectation (in the general case, not just for this
> interface)?
>
No problem.
Wei.
next prev parent reply other threads:[~2014-04-23 12:00 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 11:13 [PATCH RFC V2 00/10] xl/libxl: JSON infrastructure and new "xl-json" format Wei Liu
2014-04-17 11:13 ` [PATCH RFC V2 01/10] libxl IDL: rename json_fn to json_gen_fn Wei Liu
2014-04-17 11:13 ` [PATCH RFC V2 02/10] libxl_json: introduce libx__object_from_json Wei Liu
2014-04-22 14:49 ` Ian Campbell
2014-04-17 11:13 ` [PATCH RFC V2 03/10] libxl_internal: make JSON_* types bit-field Wei Liu
2014-04-22 14:50 ` Ian Campbell
2014-04-17 11:13 ` [PATCH RFC V2 04/10] libxl_internal: introduce libxl__json_object_is_{null, number, double} Wei Liu
2014-04-17 11:13 ` [PATCH RFC V2 05/10] libxl_json: introduce parser functions for builtin types Wei Liu
2014-04-22 15:09 ` Ian Campbell
2014-04-23 10:01 ` Wei Liu
2014-04-23 10:12 ` Ian Campbell
2014-04-23 10:19 ` Wei Liu
2014-04-23 10:31 ` Ian Campbell
2014-04-23 10:42 ` Wei Liu
2014-04-23 11:14 ` Wei Liu
2014-04-23 11:41 ` Ian Campbell
2014-04-23 12:00 ` Wei Liu [this message]
2014-04-24 15:28 ` Ian Jackson
2014-04-23 15:20 ` Wei Liu
2014-04-24 15:29 ` Ian Jackson
2014-04-17 11:13 ` [PATCH RFC V2 06/10] libxl_json: allow basic JSON type objects generation Wei Liu
2014-04-22 15:22 ` Ian Campbell
2014-04-23 10:15 ` Wei Liu
2014-04-23 10:30 ` Ian Campbell
2014-04-23 10:36 ` Wei Liu
2014-04-23 11:39 ` Ian Campbell
2014-04-17 11:13 ` [PATCH RFC V2 07/10] libxl/gentypes.py: generate JSON object for keyed-union discriminator Wei Liu
2014-04-22 15:27 ` Ian Campbell
2014-04-22 15:32 ` Wei Liu
2014-04-17 11:13 ` [PATCH RFC V2 08/10] libxl IDL: generate code to parse libxl__json_object to libxl_FOO struct Wei Liu
2014-04-22 15:46 ` Ian Campbell
2014-04-22 15:54 ` Wei Liu
2014-04-22 16:01 ` Ian Campbell
2014-04-22 16:12 ` Wei Liu
2014-04-17 11:13 ` [PATCH RFC V2 09/10] libxl/gentest.py: test JSON parser Wei Liu
2014-04-22 15:47 ` Ian Campbell
2014-04-22 15:49 ` Wei Liu
2014-04-22 15:58 ` Ian Campbell
2014-04-17 11:13 ` [PATCH RFC V2 10/10] xl: introduce "xl-json" format Wei Liu
2014-04-19 8:35 ` Wei Liu
2014-04-22 10:15 ` Ian Campbell
2014-04-22 10:25 ` Wei Liu
2014-04-22 10:33 ` Ian Campbell
2014-04-22 13:50 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423120029.GD7712@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).