From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [V9 PATCH 7/8] pvh dom0: check for vioapic null ptr
 in vioapic_range
Date: Wed, 23 Apr 2014 14:18:42 -0700
Message-ID: <20140423141842.04d0879f@mantra.us.oracle.com>
References: <1397607172-32065-1-git-send-email-mukesh.rathor@oracle.com>
	<1397607172-32065-8-git-send-email-mukesh.rathor@oracle.com>
	<534EC6850200007800009B08@nat28.tlf.novell.com>
	<20140416184448.25c62fb1@mantra.us.oracle.com>
	<534F96DF0200007800009D57@nat28.tlf.novell.com>
	<20140421175932.3f93d0ee@mantra.us.oracle.com>
	<53563769020000780000A8FD@nat28.tlf.novell.com>
	<20140422171159.61230575@mantra.us.oracle.com>
	<53579EED020000780000B36E@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <mukesh.rathor@oracle.com>) id 1Wd4ZH-0000nj-0b
	for xen-devel@lists.xenproject.org; Wed, 23 Apr 2014 21:18:59 +0000
In-Reply-To: <53579EED020000780000B36E@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: George.Dunlap@eu.citrix.com, tim@xen.org, eddie.dong@intel.com, keir.xen@gmail.com, jun.nakajima@intel.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 23 Apr 2014 10:07:25 +0100
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 23.04.14 at 02:11, <mukesh.rathor@oracle.com> wrote:
> > On Tue, 22 Apr 2014 08:33:29 +0100
> > "Jan Beulich" <JBeulich@suse.com> wrote:
> >> >>> On 22.04.14 at 02:59, <mukesh.rathor@oracle.com> wrote:
......

> >   So it must have been the third one that I had observed the
> >   vioapic_range crash in a while ago, and had made note of it.
> > Looking at it:
> > 
> >     if ( (p2mt == p2m_mmio_dm) ||
> >          (access_w && (p2mt == p2m_ram_ro)) )
> >     {
> >         put_gfn(p2m->domain, gfn);
> >         if ( !handle_mmio() )
> > 
> > doesn't seem apply to domu. Unfortunately, I can't reproduce it now
> > so maybe it was an ept violation due to some bug, and a crash in 
> > vioapic_range before printing the gfn/mfns etc by
> > ept_handle_violation made me make a note to put a check in it.
> 
> Which makes me think that we don't need the patch at all.

Well, without this patch, in case of dom0 EPT violation, dom0 will
not die gracefully printing gfn/mfn/etc.. info. But instead it will
show fault in vioapic_range. 


ept_handle_violation() 
       hvm_hap_nested_page_fault()
             -> handle_mmio() -----> vioapic_range() : KABOOM!!

       gdprintk(XENLOG_ERR, "EPT violation %#lx (%c%c%c/%c%c%c), "
                    "gpa %#"PRIpaddr", mfn %#lx, type %i.\n",
                                 qualification,  <=== NOT REACHED
          .......

I can submit it later too I guess. But without it, we'd not know
the ept violation crashes.

thanks
mukesh