xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George.Dunlap@eu.citrix.com, Tim Deegan <tim@xen.org>,
	eddie.dong@intel.com, keir.xen@gmail.com, jun.nakajima@intel.com,
	xen-devel@lists.xenproject.org
Subject: Re: [V9 PATCH 6/8] pvh dom0: Add and remove foreign pages
Date: Fri, 25 Apr 2014 17:06:07 -0700	[thread overview]
Message-ID: <20140425170607.01e2aedd@mantra.us.oracle.com> (raw)
In-Reply-To: <535A219B020000780000C247@nat28.tlf.novell.com>

On Fri, 25 Apr 2014 07:49:31 +0100
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 25.04.14 at 04:09, <mukesh.rathor@oracle.com> wrote:
> > Ok, how about something like shown further below?  (I think
> > it would be more simpler to have one atomic_write ops, instead of
> > two)
> 
> That's an understandable desire, but ...
> 
> > +/* returns : 0 for success, -errno otherwise */
> > +static int atomic_write_ept_entry(ept_entry_t *entryptr,
> > ept_entry_t new) +{
> > +    unsigned long oldmfn;
> > +    struct domain *fdom;
> > +    bool_t new_foreign = p2m_is_foreign(new.sa_p2mt);
> > +    bool_t old_foreign = p2m_is_foreign(entryptr->sa_p2mt);
> 
> ... these aren't really valid for intermediate entries (they just end
> up getting p2m_ram_rw put into them right now, but that's in no way
> explicit, and hence not set in stone). As said before, I can see the
> need to use these fields eventually, so this would end up being a
> latent problem. Hence minimally I'd want you to explicitly set the
> field in ept_set_middle_entry() to make clear that we now depend on
> it having a certain value.

BTW, one thing that is confusing looking at the code is :

ept_memory_type_changed() calls ept_invalidate_emt with PML4 mfn.
ept_invalidate_emt walks l4 entries checking for emt and doing
atomic_write_ept_entry on l4 entries. However, looking at latest 
intel SDM figure 28-1, vol 3b, it appears those bits are reserved?
EPT MT is only valid for L3, l2 and l1. What am I missing?

thanks
mukesh

  parent reply	other threads:[~2014-04-26  0:06 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16  0:12 [V9 PATCH 0/8] pvh dom0 patches Mukesh Rathor
2014-04-16  0:12 ` [V9 PATCH 1/8] pvh dom0: move some pv specific code to static functions Mukesh Rathor
2014-04-16  0:12 ` [V9 PATCH 2/8] pvh dom0: construct_dom0 changes Mukesh Rathor
2014-04-16  0:12 ` [V9 PATCH 3/8] pvh dom0: Introduce p2m_map_foreign Mukesh Rathor
2014-04-16  0:12 ` [V9 PATCH 4/8] pvh dom0: Add checks and restrictions for p2m_is_foreign Mukesh Rathor
2014-04-16 15:28   ` Jan Beulich
2014-04-16  0:12 ` [V9 PATCH 5/8] pvh dom0: make xsm_map_gmfn_foreign available for x86 Mukesh Rathor
2014-04-16 14:29   ` Daniel De Graaf
2014-04-16  0:12 ` [V9 PATCH 6/8] pvh dom0: Add and remove foreign pages Mukesh Rathor
2014-04-16 16:00   ` Jan Beulich
2014-04-17  1:37     ` Mukesh Rathor
2014-04-17  6:50       ` Jan Beulich
2014-04-17 12:36         ` Tim Deegan
2014-04-17 13:58           ` Jan Beulich
2014-04-19  0:59             ` Mukesh Rathor
2014-04-21 16:10               ` Jan Beulich
2014-04-24  2:21             ` Mukesh Rathor
2014-04-24  6:44               ` Jan Beulich
2014-04-24  9:46               ` Tim Deegan
2014-04-25  2:09                 ` Mukesh Rathor
2014-04-25  6:49                   ` Jan Beulich
2014-04-25 23:23                     ` Mukesh Rathor
2014-04-26  0:06                     ` Mukesh Rathor [this message]
2014-04-28  7:23                       ` Jan Beulich
2014-04-25  8:55                   ` Tim Deegan
2014-04-25 23:29                     ` Mukesh Rathor
2014-04-26  1:34                   ` Mukesh Rathor
2014-04-28  8:54                     ` Jan Beulich
2014-04-28  9:09                       ` Tim Deegan
2014-04-22  0:19       ` Mukesh Rathor
2014-04-22  7:28         ` Jan Beulich
2014-04-23  0:28           ` Mukesh Rathor
2014-04-23  9:03             ` Jan Beulich
2014-04-23 16:13               ` Andres Lagar-Cavilla
2014-04-24 16:37                 ` Tim Deegan
2014-04-16  0:12 ` [V9 PATCH 7/8] pvh dom0: check for vioapic null ptr in vioapic_range Mukesh Rathor
2014-04-16 16:05   ` Jan Beulich
2014-04-17  1:44     ` Mukesh Rathor
2014-04-17  6:54       ` Jan Beulich
2014-04-22  0:59         ` Mukesh Rathor
2014-04-22  7:33           ` Jan Beulich
2014-04-23  0:11             ` Mukesh Rathor
2014-04-23  9:07               ` Jan Beulich
2014-04-23 21:18                 ` Mukesh Rathor
2014-04-24  6:49                   ` Jan Beulich
2014-04-24 23:28                     ` Mukesh Rathor
2014-05-06  0:19                     ` Mukesh Rathor
2014-05-06  7:44                       ` Jan Beulich
2014-05-07  1:07                         ` Mukesh Rathor
2014-05-07  6:47                           ` Jan Beulich
2014-05-07 23:52                             ` Mukesh Rathor
2014-05-08  6:33                               ` Jan Beulich
2014-04-16  0:12 ` [V9 PATCH 8/8] pvh dom0: add opt_dom0pvh to setup.c Mukesh Rathor
2014-04-16 12:57   ` Konrad Rzeszutek Wilk
2014-04-16 13:01   ` Andrew Cooper
2014-04-16 16:09   ` Jan Beulich
2014-04-16 14:57 ` [V9 PATCH 0/8] pvh dom0 patches Roger Pau Monné
2014-04-16 21:15   ` Mukesh Rathor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140425170607.01e2aedd@mantra.us.oracle.com \
    --to=mukesh.rathor@oracle.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=eddie.dong@intel.com \
    --cc=jun.nakajima@intel.com \
    --cc=keir.xen@gmail.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).