From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>,
"Jan Rękorajski" <baggins@pld-linux.org>,
"Ian Jackson" <ian.jackson@eu.citrix.com>,
"Jacek Konieczny" <jajcus@jajcus.net>,
"M A Young" <m.a.young@durham.ac.uk>,
xen-devel@lists.xenproject.org,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Subject: Re: [PATCH v2 6/7] tools/xendomains: move to sbin and use init helper
Date: Mon, 28 Apr 2014 07:11:19 +0200 [thread overview]
Message-ID: <20140428051119.GA11838@wotan.suse.de> (raw)
In-Reply-To: <1395655795.19365.16.camel@kazak.uk.xensource.com>
On Mon, Mar 24, 2014 at 10:09:55AM +0000, Ian Campbell wrote:
> On Sat, 2014-03-22 at 03:17 +0100, Luis R. Rodriguez wrote:
> > What I mean by keeping the history is you can do git log --follow on the
> > script after the move.
>
> The history is never lost. If git was actually losing history there
> would be uproar, and the structure of the repo prevents it anyway.
>
> I skanked up an example commit (see below) and git comes up with:
> 2 files changed, 54 insertions(+), 610 deletions(-)
> rewrite tools/hotplug/Linux/init.d/xendomains (91%)
> rename tools/hotplug/Linux/{init.d => }/xendomains (93%)
> and "git log --follow tools/hotplug/Linux/xendomains" works exactly as I
> expected, so I think things are fine.
Did you try git format-patch -M on that? I now see what you see but I don't
see git format-patch respecting the rename detection, either way we'll know
it will be so I'll just submit it, just to be clear on the submission
that I just move the code, its not a magical rewrite.
Luis
next prev parent reply other threads:[~2014-04-28 5:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 20:58 [PATCH v2 0/7] xen: add systemd files Luis R. Rodriguez
2014-03-19 20:58 ` [PATCH v2 1/7] xenstore-read: add support for a retry open limit on xenstored Luis R. Rodriguez
2014-03-21 15:21 ` Ian Campbell
2014-03-21 15:22 ` Ian Jackson
2014-03-22 1:36 ` Luis R. Rodriguez
2014-03-22 1:33 ` Luis R. Rodriguez
2014-03-24 9:57 ` Ian Campbell
2014-03-21 15:40 ` David Vrabel
2014-03-21 16:01 ` Ian Campbell
2014-03-22 1:43 ` Luis R. Rodriguez
2014-03-24 10:01 ` Ian Campbell
2014-03-22 1:41 ` Luis R. Rodriguez
2014-03-19 20:58 ` [PATCH v2 2/7] xencommons: use the retry limit instead of implementing our own timeout Luis R. Rodriguez
2014-03-21 15:24 ` Ian Campbell
2014-03-19 20:58 ` [PATCH v2 3/7] tools/xendomains: make xl the default Luis R. Rodriguez
2014-03-21 15:26 ` Ian Campbell
2014-03-19 20:58 ` [PATCH v2 4/7] tools/xendomains: remove old redhat check Luis R. Rodriguez
2014-03-21 15:28 ` Ian Campbell
2014-03-22 1:56 ` Luis R. Rodriguez
2014-03-19 20:58 ` [PATCH v2 5/7] tools/xendomains: do space cleanups Luis R. Rodriguez
2014-03-21 15:29 ` Ian Campbell
2014-03-19 20:58 ` [PATCH v2 6/7] tools/xendomains: move to sbin and use init helper Luis R. Rodriguez
2014-03-19 22:03 ` Olaf Hering
2014-03-22 2:00 ` Luis R. Rodriguez
2014-03-21 15:34 ` Ian Campbell
2014-03-22 2:17 ` Luis R. Rodriguez
2014-03-24 10:09 ` Ian Campbell
2014-04-28 5:11 ` Luis R. Rodriguez [this message]
2014-04-28 9:15 ` Ian Campbell
2014-04-28 10:47 ` Luis R. Rodriguez
2014-03-19 20:58 ` [PATCH v2 7/7] systemd: add support initial xen systemd service files Luis R. Rodriguez
2014-03-19 21:05 ` Luis R. Rodriguez
2014-03-21 10:08 ` Ian Campbell
2014-03-22 2:26 ` Luis R. Rodriguez
2014-03-24 10:11 ` Ian Campbell
2014-03-24 16:36 ` Luis R. Rodriguez
2014-04-28 5:12 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428051119.GA11838@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=Ian.Campbell@citrix.com \
--cc=baggins@pld-linux.org \
--cc=ian.jackson@eu.citrix.com \
--cc=jajcus@jajcus.net \
--cc=m.a.young@durham.ac.uk \
--cc=mcgrof@do-not-panic.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).