From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Rathor Subject: Re: [PATCH RFC 21/23] gdbsx: remove cast from ioctl Date: Mon, 28 Apr 2014 12:42:39 -0700 Message-ID: <20140428124239.3122894c@mantra.us.oracle.com> References: <1397657612-57277-1-git-send-email-roger.pau@citrix.com> <1397657612-57277-22-git-send-email-roger.pau@citrix.com> <21328.3271.484446.176928@mariner.uk.xensource.com> <1398696386.29700.147.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WerS1-0005Lo-By for xen-devel@lists.xenproject.org; Mon, 28 Apr 2014 19:42:53 +0000 In-Reply-To: <1398696386.29700.147.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Ian Jackson , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org On Mon, 28 Apr 2014 15:46:26 +0100 Ian Campbell wrote: > On Thu, 2014-04-17 at 18:17 +0100, Ian Jackson wrote: > > Roger Pau Monne writes ("[PATCH RFC 21/23] gdbsx: remove cast from > > ioctl"): > > > The ulong type is not defined on FreeBSD, and the cast seems > > > pointless, so just remove it. > > > > I think this is very likely to be correct. > > The danger is systems where sizeof(ulong) != sizeof(struct somehing > *). I think we can sleep easy and not worry about that. > > > Acked-by: Ian Jackson > > Agreed. Acked-by: Ian Campbell > > Ian. Acked-by: Mukesh Rathor