From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [PATCH v4 11/15] autoconf: xen: move standard variables to a generic place Date: Wed, 30 Apr 2014 19:53:30 +0200 Message-ID: <20140430175330.GI11838@wotan.suse.de> References: <1398820328-15132-1-git-send-email-mcgrof@do-not-panic.com> <1398820328-15132-12-git-send-email-mcgrof@do-not-panic.com> <5360B9CB020000780000D9BB@suse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4945765309666342392==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WfYhI-0002Ug-R2 for xen-devel@lists.xenproject.org; Wed, 30 Apr 2014 17:53:33 +0000 In-Reply-To: <5360B9CB020000780000D9BB@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , Ian Campbell , "Luis R. Rodriguez" , Tim Deegan , Ian Jackson , xen-devel@lists.xenproject.org, Samuel Thibault List-Id: xen-devel@lists.xenproject.org --===============4945765309666342392== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EXKGNeO8l0xGFBjy" Content-Disposition: inline --EXKGNeO8l0xGFBjy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 30, 2014 at 12:52:27AM -0600, Jan Beulich wrote: > >>> On 30.04.14 at 03:12, wrote: > > This moves all generic variables to the top level makefile, > > tons of files use these so just make them general enough. This > > also paves the way to let us easily dynamically configure these > > with autoconf, for now we leave the same presets as was present > > before. >=20 > Am I right understanding that this then will require ./configure to > be run even for hypervisor-only building? Its unclear what you mean by that, can you describe what is required to accomplish this on a fresh git tree. Can you describe what expectations you have on build time to see if this patch breaks that and if so see what can be done to avoid this? All the changes I did here really was to toss around variables to be set through autoconf and if building the hypervisor requries them then yes, but fixing that should be as easy as adding schecks to add sensible defaults if configure has not been run. > If so, I objected to that > idea already when the configuration process got introduced, and > I continue to do so now. OK Luis --EXKGNeO8l0xGFBjy Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAEBAgAGBQJTYTiaAAoJEPep4JnvMe6z6xAP/1DrvOOyZfLyfdi0HZJItlFF Eqy3ozxl/AbrSlqTVdHpBVUJUAyBRW69X1mtR3zUN5ZHMJg+t+/XXker1QcAoMSF v4I3qtWO9fv2P2WkgTjtk3X99PyuqCON18mcVwq2Kiyw9IYwDQEbF5sxAytUUys6 +bWj7aMtBYcu5M0wIXJb4TkCxvaJhFnmNsvdHnirT8xbbRpi6I9CWOzmR1qJ3FxB IEgUgwrgDIWgzS7JLyqRHLbYoG66mIycXUDRZLVCvTAcre9U0twYNnUaxzFpn9Go 5wVWuyyepu+rLIoBASkoNGFommSgIO2sz2y24ig/q4VmSil76ZReYsiZX/PXpjqe UhQdTAL0LU0dGOf8FWz6xhe8t2VpiTo5XO4omm+dzum62CdDI6mGlPooLW7AOnkh lKMdWx21skXTXSFXsakWT8oK2+e3EXjQC9Gt26ZjmkEvd5BOo05Ou/IhCxw9LC6E 5WBYnUNKBJBocSLbSExUYGa6NaeDWYym78d8iwN1mhxlUza9lhiEVDcnw8fZ0t/a pRJvsEd0wTQLqkoziWZze2fOvaT4AKpbYfjVcjN1tRPHkyZSHUY70TMyqu1qRe3F b3W0ZiQdcp4/8VOsugY01cJlhAvVPhFQiUVKCCsqnaxNoGoPS85+uzQIhCsthuE5 +FYUn0qEAykHRllTP+Z/ =HZrS -----END PGP SIGNATURE----- --EXKGNeO8l0xGFBjy-- --===============4945765309666342392== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4945765309666342392==--